Ignore TypeScript major bumps in Dependabot - #512
Merged
Conversation
TypeScript 7 is the native compiler rewrite. tsup's bundled rollup-plugin-dts targets the TS 5.x compiler API and cannot emit the package's .d.ts declarations under TS 7 (the build fails with 'Cannot read properties of undefined (reading useCaseSensitiveFileNames)'). This bump also poisoned the whole dev-dependencies group PR (#503), keeping otherwise-safe minor/patch updates from landing. Ignore only the major version-update for typescript; minor/patch within the current major keep flowing, and we can lift this once tsup/rollup-plugin-dts support TS 7.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #512 +/- ##
=======================================
Coverage 94.87% 94.87%
=======================================
Files 2 2
Lines 78 78
Branches 20 20
=======================================
Hits 74 74
Misses 1 1
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Dependabot
ignorerule so it stops proposing TypeScript major upgrades.Why
TypeScript 7 is the native compiler rewrite.
tsup's bundledrollup-plugin-dts@6.1.1targets the TS 5.x compiler API and cannot emit the package's.d.tsunder TS 7 — the build throws:Since the published package is its type declarations, that's a hard blocker. Verified locally: under TS 7, typecheck and tests pass but
npm run buildfails at the DTS step.This bump was also grouped into the
dev-dependenciesPR (#503) and turned the whole group red, blocking otherwise-safe minor/patch updates from landing.Change
Scoped to major only — TypeScript minor/patch within the current major still flow normally. Lift this once
tsup/rollup-plugin-dtssupport TS 7.Follow-up (not in this PR)