install: report actual errors for special-file targets - #13645
install: report actual errors for special-file targets#13645Hashim1999164 wants to merge 2 commits into
Conversation
Let existing non-directory targets reach the normal replacement path so unlink failures report their real operating-system error.
Merging this PR will degrade performance by 18.3%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | df_with_path |
571.4 µs | 699.4 µs | -18.3% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing Hashim1999164:fix/install-special-file-target (30e180a) with main (21d4e96)
Footnotes
-
46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
|
GNU testsuite comparison: |
|
The failing CI jobs look unrelated to this change ( |
|
Merged latest main to refresh CI after unrelated chgrp test failures on the previous run. |
Summary
Fixes #9934
Validation
cargo fmt --checkcargo test --features install --no-default-features test_install_replaces_special_target(1 passed)cargo test --features install --no-default-features test_install::(98 passed)cargo clippy --features install --no-default-features --all-targets -- -D warnings