Skip to content

install: report actual errors for special-file targets - #13645

Open
Hashim1999164 wants to merge 2 commits into
uutils:mainfrom
Hashim1999164:fix/install-special-file-target
Open

install: report actual errors for special-file targets#13645
Hashim1999164 wants to merge 2 commits into
uutils:mainfrom
Hashim1999164:fix/install-special-file-target

Conversation

@Hashim1999164

@Hashim1999164 Hashim1999164 commented Jul 29, 2026

Copy link
Copy Markdown

Summary

  • let existing special-file destinations reach the normal replacement path instead of reporting them as missing
  • add a FIFO regression test that verifies special targets are replaced safely

Fixes #9934

Validation

  • cargo fmt --check
  • cargo test --features install --no-default-features test_install_replaces_special_target (1 passed)
  • cargo test --features install --no-default-features test_install:: (98 passed)
  • cargo clippy --features install --no-default-features --all-targets -- -D warnings

Let existing non-directory targets reach the normal replacement path so
unlink failures report their real operating-system error.
@codspeed-hq

codspeed-hq Bot commented Jul 30, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 18.3%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 346 untouched benchmarks
⏩ 46 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation df_with_path 571.4 µs 699.4 µs -18.3%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing Hashim1999164:fix/install-special-file-target (30e180a) with main (21d4e96)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)

@Hashim1999164

Copy link
Copy Markdown
Author

The failing CI jobs look unrelated to this change (test_chgrp::test_reference environment/group assertion). Happy to rebase or re-run if maintainers want a fresh check.

@Hashim1999164

Copy link
Copy Markdown
Author

Merged latest main to refresh CI after unrelated chgrp test failures on the previous run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

install /dev/null /dev/full has wrong error message

1 participant