sort: defer compress program errors until needed - #13656
Conversation
|
GNU testsuite comparison: |
d468737 to
8ab9b62
Compare
Merging this PR will improve performance by 3.97%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | du_summarize_balanced_tree[(5, 4, 10)] |
16.5 ms | 15.8 ms | +4.1% |
| ⚡ | Simulation | du_wide_tree[(5000, 500)] |
20.2 ms | 19.5 ms | +3.84% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing wtcpython:sort-compress-error-priority (a97b03b) with main (2c9a666)
Footnotes
-
50 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
828477d to
95b0ea3
Compare
95b0ea3 to
9fe5d79
Compare
|
Binary size comparison: |
9fe5d79 to
d14f018
Compare
|
Would you mind taking a look when convenient? Thanks! |
| if let Some((prog, err)) = compress_prog_error { | ||
| let _ = writeln!( | ||
| stderr(), | ||
| "sort: could not run compress program '{prog}': {}", |
There was a problem hiding this comment.
Please use the translate macro
| "nonexistent-program", | ||
| "-S", | ||
| "10", | ||
| "1K", |
d14f018 to
a97b03b
Compare
Fixes #13148.
Defer reporting compression program errors until external sorting is required, allowing earlier input errors to be reported without an unrelated compression warning.