Experiments - #486
Open
dferber90 wants to merge 18 commits into
Open
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dferber90
marked this pull request as ready for review
August 31, 2026 12:15
dferber90
marked this pull request as draft
August 31, 2026 12:15
| entities?: E, | ||
| ): Promise<void> => { | ||
| try { | ||
| const instance = controllerInstanceMap.get(id); |
Contributor
There was a problem hiding this comment.
Shouldn't we also check if reporting is disabled before doing all the below work? I know it is also checked in the report method, but we could save us some work if we do a check here already and return early.
| const variantIndex = definition.variants.findIndex( | ||
| (variant) => | ||
| Object.is(variant, value) || | ||
| JSON.stringify(variant) === serializedValue, |
Contributor
There was a problem hiding this comment.
Isn't this a bit tricky with JSON values? They could contain the same keys but in a different order. So their content would technically be the same, just stringifying and comparing would say they're different.
vincent-derks
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An exploration of experimentation features