fix: preserve JavaFX suffix when selecting Java versions - #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting an installed JavaFX distribution such as
8.0.482+8-zulu-fxincorrectly resolved to8.0.482+8-zulu, causing vfox to report it as not installed. Preserve the JavaFX suffix when PreUse normalizes the distribution name.Add eight offline regression cases covering JavaFX suffixes, distribution aliases and ordering, ordinary versions, and the existing major-version fallback, and run them in CI.
Validation: reproduced the original failure before the fix; all regression cases pass with GopherLua 1.1.1; actual vfox 1.0.12 plugin runtime checks pass; plugin package validation and actionlint pass.
Fixes #53