Skip to content

fix(core): observe dock sidebar size in the popup's own realm #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SaKaNa-Y wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −3
Open

fix(core): observe dock sidebar size in the popup's own realm #521

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions packages/core/src/client/webcomponents/components/dock/DockGroupSidebar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<script setup lang="ts">
import type { DevToolsDockEntry, DevToolsViewGroup } from '@vitejs/devtools-kit'
import type { DocksContext } from '@vitejs/devtools-kit/client'
import { useElementBounding, watchDebounced } from '@vueuse/core'
import { computed, h, ref, useTemplateRef } from 'vue'
import { watchDebounced } from '@vueuse/core'
import { computed, h, ref, useTemplateRef, watch } from 'vue'
import { deriveSidebarCapacity, docksSplitGroupsWithCapacity, getGroupMembersGrouped } from '../../state/dock-settings'
import { sharedStateToRef } from '../../state/docks'
import { setDocksSidebarOverflowPanel, setFloatingTooltip, useDocksSidebarOverflowPanel } from '../../state/floating-tooltip'
Expand Down Expand Up @@ -36,7 +36,24 @@ const memberGroups = computed(() => getGroupMembersGrouped(
))

const sidebar = useTemplateRef<HTMLDivElement>('sidebar')
const { height: frameHeight } = useElementBounding(sidebar)

const frameHeight = ref(0)
watch(sidebar, (el, _prev, onCleanup) => {
if (!el) {
frameHeight.value = 0
return
}
const ResizeObserverCtor = el.ownerDocument?.defaultView?.ResizeObserver ?? globalThis.ResizeObserver
if (!ResizeObserverCtor)
return
const observer = new ResizeObserverCtor(([entry]) => {
if (!entry)
return
frameHeight.value = entry.borderBoxSize?.[0]?.blockSize ?? entry.contentRect.height
})
observer.observe(el)
onCleanup(() => observer.disconnect())
}, { immediate: true, flush: 'post' })

const totalItems = computed(() => memberGroups.value.reduce((acc, [, items]) => acc + items.length, 0))

Expand Down
Loading