Take rustls past RUSTSEC-2026-0285 - #127
Closed
vmillet-dev wants to merge 1 commit into
Closed
vmillet-dev wants to merge 1 commit into
vmillet-dev wants to merge 1 commit into
Conversation
TLS 1.3 handshake messages were accepted across encryption level boundaries. The handshake transcript stays authenticated, so a network-position attacker cannot alter or complete one — the effect is that a peer could send in plaintext what should have been encrypted without the connection being rejected. Reached through tauri-plugin-updater, which is the only thing here that speaks TLS. Both packages named on one command: 0.23.45 wants webpki ^0.103.14 and the lockfile held 0.103.13, so updating rustls alone falls back to 0.23.43 — which is still below the fix — rather than move a sibling. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
vmillet-dev
force-pushed
the
fix/rustls-advisory
branch
from
September 15, 2026 16:00
fb3e2a3 to
724be13
Compare
Owner
Author
|
Folded into #126 — the advisory is what turned that PR's Security job red, so the fix belongs on the branch that has to go green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cargo advisories and licenseswent red, and not because of the PR it went redon.
rustls 0.23.42has been in the lockfile since before today; the advisorywas published between
main's last Security run this morning and now, and #126happened to be the first run after it.
The handshake transcript stays authenticated, so a network-position attacker
cannot alter or complete a handshake. The practical effect is narrower: a peer
could send in plaintext what should have been encrypted, and rustls would not
reject the connection. Functionally the same bug as Go's CVE-2025-61730.
tauri-plugin-updateris the only thing in this tree that speaks TLS.cargo update -p rustlsalone stops at 0.23.43, still below the fix:0.23.45 requires
webpki ^0.103.14and the lockfile held0.103.13. Asingle-package update is conservative and will not move a sibling to satisfy the
one it was asked about, so it falls back to the newest release that accepts what
is already locked — 0.23.43, whose requirement is
^0.103.5. Naming both letsthe resolver move them together:
Lockfile only. No
--precisepin and no MSRV change — every crate involveddeclares
rust-version = "1.71", sorust-version = "1.88"was never the gate,and raising it as far as 1.93 changes nothing. Cargo's "latest Rust 1.88
compatible version" line is what made it look like one.
Checked locally
cargo testall green,cargo clippy --all-targets -D warningsandcargo fmt --checkclean.🤖 Generated with Claude Code