Draw every row of a todo list inside the card that holds it - #204
Merged
Merged
Conversation
Growing a row to 24px in #176 pushed the list past the 53 pixels a card leaves it, and .card-items is anchored to the bottom with overflow hidden — so the first row was drawn nine pixels above its own box and cut in half. Measured before anything was touched, and again after. The card does not get taller. folders/board.rs carries CARD_HEIGHT = 150 and every zone frame is computed from it, so raising it crosses the bridge and leaves boards that already exist with zones a row's worth too short. The fourteen pixels come back instead. "+N autres" moves onto the progress line, beside the count that already states the total: nothing disappears, the card does not move, the bridge is untouched. And the assertion that was missing. The suite checked both rows were in the DOM and that the badge agreed, and both passed the whole time the row was cut — neither asks whether a row is drawn inside its container. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #200.
Reproduced before anything was touched
Where a card's 150px goes, measured rather than guessed: title 17, progress 13 (+8 of margin), list 53, footer 13. The list was asking for 24 + 24 + 14 — those 14 being the "+N autres" line, which lives inside it.
.card-itemsisflex: 1withjustify-content: flex-endandoverflow: hidden, so the overflow leaves through the top. That is why the first row went and not the last.Why the card did not simply get taller
That was my own preferred shape in the ticket, and it is dearer than it looks:⚠️ It is a cross-bridge constant, and zones already stored were sized against the old value — they would come up short by a row's worth of pixels, on boards that already exist.
folders/board.rscarriesCARD_HEIGHT: i32 = 150, and every zone frame on the board is computed from it.So the fourteen pixels are given back rather than added: "+N autres" moves onto the progress line, beside the
1/6that already states the total. Nothing disappears, the card does not move, and the bridge is untouched.The assertion #176 needed and did not have
07-checklistsalready checked that both rows are in the DOM and that the badge agrees withMAX_VISIBLE_ITEMS. Both passed the entire time the row was cut in half — neither asks whether a row is drawn inside its container.Zero pixels outside the box, per row. That is the test that would have failed the day #176 landed.
Looked at
Built the old state back to photograph it, so the before is the same card at the same width rather than a report screenshot. Both images are in the conversation; the clipped row is unmistakable in one and whole in the other.
🤖 Generated with Claude Code