Spend a card's two rows on what is left to do - #206
Merged
Merged
Conversation
A checklist card drew a flat slice of the list, so a ticked item kept its seat while the things still to do sat behind '+N autres'. The preview is a selection now: the item a search matched keeps its place whatever its state, the remaining seats go to what is undone, and a finished list falls back on its last items rather than going blank. Each row carries the position it holds in the note, so ticking no longer has a window offset to get wrong. Closes #202
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #202.
A checklist card drew a flat slice of the list, so ticking the first item kept its
seat: half the preview went to something already done while the things still to do
sat behind "+N autres".
The preview is a selection now, not a slice:
is on screen;
the top of a finished list saying the least about where it ended;
hiddenItemCountcounts what was not drawn rather than assuming a tail.Each row now carries the position it holds in the note, so
onItemTogglehas nowindow offset left to get wrong.
A choice worth a second opinion
When a search matched an item, the other row goes to the first undone item rather
than to the matched one's neighbour. That is the ticket's headline applied
consistently — one rule for "who gets the remaining seats" instead of two. Say so if
you would rather keep the old contiguous window whenever a search is active.
Verified
Unit: 1354/1354, four new specs that fail on the old code. E2E: 21/21 locally.
Three scenarios added to
07-checklists, and the three existing ones whoseexpectations the new rule moves were updated rather than dropped.