Rename the application to DevNotes - #211
Merged
Merged
Conversation
The displayed name comes from `[package.metadata.devnotes] display-name`
and reaches every translated string through `{{app}}` on its own; the
crate, the binary, the Angular project and the repository slug follow it.
The four names that make up a library's address — the Tauri identifier,
`devnotes.sqlite3`, the `devnotes.` preference prefix and the `.devnotes`
export extension — moved with it rather than waiting for a startup
migration, since nothing is installed anywhere yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DevBoxwas named for a Swiss-army-knife premise that no longer exists — the crypto andformatter modules were removed once it became clear they would ship dead code. What ships
is a notes and snippets manager, and the name now says so.
What it cost, and what it did not
The displayed name was one line.
[package.metadata.devnotes] display-namereachesDEVNOTES_DISPLAY_NAME→APP_METADATA.name→APP_INFO.name→ the 22 translatedstrings per locale that write
{{app}}. No translated string spells the name out, andtransloco-loader.spec.tsstill holds that.Three things escaped that channel and were renamed by hand: the OS window title in
tauri.conf.json, the sample tag (notes.samples.tags.devnotes— the guard comparesagainst
APP_INFO.nameand is case-sensitive, so a lowercasedevboxslipped past it),and the assertions in six spec files.
The four names that are a library's address
identifiercom.devbox.appcom.devnotes.appdb::DB_FILE_NAMEdevbox.sqlite3(+-wal,-shm)devnotes.sqlite3devbox.<key>devnotes.<key>.devbox.devnotesapp_data_dir()isdata_dir()/identifier, so these four decide where every librarylives. Moving them normally needs a startup migration that adopts the old directory —
without one, an installed copy opens on a virgin profile with the notes still on disk and
no way in, since the key file is what opens the database.
They moved anyway, and deliberately: the application has no users yet. The
⚠️inCLAUDE.mdnow records the constraint rather than the exemption, so the next renamecannot be done with a
sed.Verified
cargo check·clippy -D warnings·fmt --check·cargo test(486) ·npm test(1354) ·npm run test:scripts(34) ·npm run lint·npm run build·npm run bindings(regenerated, no drift).npm run test:e2e: 21/21 spec files, against the assembled binary carrying the newidentifier.
com.devnotes.app.e2ewas created from nothing and01-first-launchmet thevirgin profile it expects — which is the only proof that the identifier rename works end
to end.
One thing this PR cannot do
The updater endpoint now points at
github.com/vmillet-dev/devnotes-rs. The repositoryhas to be renamed before the next release, or the manifest resolves to nothing. GitHub
keeps the old → new redirect, so the releases already out keep updating.