Sweep a selection band with the right button - #300
Merged
Merged
Conversation
The left button still draws a folder — it had the background first, and it is the gesture that creates something. Which cards a band swept is measured off the screen: a filed card flows and has no coordinates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #248.
The board had selection one card at a time, through the tick in the card's corner. A held right click dragged across the surface now delimits a selection area, the same way the left one delimits a folder.
The existing gesture does not move. The left button still draws a folder — it had the background first, and it is the one that creates something.
Two things the decision settles:
Ctrl+clickalready added to a selection on both views, so the modifier half of the ticket needed nothing.And the one it opened: the application has no context menu anywhere, so
contextmenuis simply suppressed on the surface. Without it the browser's own menu opens at the end of every sweep, right where the pointer was lifted. A right click that never travels still does nothing.Two details worth the review
overlapsis the arithmetic, half-open on the far edges likecontains, and touching is enough.editableis false: it writes nothing to the board, it only ticks what is already drawn.The band is drawn in amber against the folder band's neutral outline — the left button draws a region that will exist, the right one sweeps a selection that will not.
1429 front-end tests (ten new: five on the arithmetic, five driving the pointer) and the full e2e suite green locally — 21/21, with five new scenarios including one that proves the left button still makes a folder.