New package: fcitx5-lotus-3.4.0 - #61742
Conversation
116b7a1 to
43fb043
Compare
43fb043 to
067d9dd
Compare
|
Sorry for the mess and noise in the commit history earlier! I've cleaned it all up into a single commit containing only fcitx5-lotus. Thank you for your patience! |
|
Package description: Technical notes: Notes from the Packager: |
b15768f to
c44d95c
Compare
c44d95c to
62f86c3
Compare
62f86c3 to
449020a
Compare
| makedepends="libfcitx5-devel libinput-devel eudev-libudev-devel acl-devel libX11-devel" | ||
| depends="fcitx5 acl hicolor-icon-theme" | ||
| short_desc="Vietnamese input method engine for Fcitx5" | ||
| maintainer="Leanhduc <259352926+0353618151hao-png@users.noreply.github.com>" |
There was a problem hiding this comment.
The emails must be real emails, not noreply emails.
| configure_args="-DINSTALL_RUNIT=ON" | ||
| hostmakedepends="extra-cmake-modules pkg-config gettext go python3" | ||
| makedepends="libfcitx5-devel libinput-devel eudev-libudev-devel acl-devel libX11-devel" | ||
| depends="fcitx5 acl hicolor-icon-theme" |
There was a problem hiding this comment.
Adding hicolor-icon-theme here is wrong. The package works completely fine without using the icons, so there's no reason to add that dependency.
07a61c5 to
b164537
Compare
|
Thanks for the review! I've updated the PR according to your feedback:
|
7eef959 to
ceb27ad
Compare
ceb27ad to
d4e5987
Compare
Testing: Built and tested on glibc x86_64.