New package: for-desktop-1.5.3 - #62553
Open
PedroCarreiras wants to merge 1 commit into
Open
PedroCarreiras wants to merge 1 commit into
PedroCarreiras wants to merge 1 commit into
Conversation
add package for stoat-desktop, named for-desktop upstream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add package for stoat-desktop
Testing the changes
New package
Local build testing
Notes
This is my first contribution to void and I have some doubts about it. For one, the upstream repo has a very non descriptive name (for-desktop). I left it as is, as per the guide, and added the name of the program in the short description.
I also looked at other packages to follow them as examples but I feel my post_extract step might be a bit of a hack that could be done in a more standard fashion, although I was not able to find a similar case.
Furthermore, as newbie in general when it comes to packaging software, I am unsure whether I copied more files than necessary to the /usr/lib folder.
Lastly, I was not able to build for other architectures, but I did try.
I await feedback and look forward to learn from this PR and go on to contribute more to the void packages in the future.