Skip to content

wlclock: Fix argv parse on musl - #62592

Open
orahcio wants to merge 1 commit into
void-linux:masterfrom
orahcio:fix-wlclock-argv
Open

orahcio wants to merge 1 commit into
void-linux:masterfrom
orahcio:fix-wlclock-argv

Conversation

@orahcio

@orahcio orahcio commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Fix issue #62586 according FreeBSD patch.

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, (x86_64-musl)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):

@ahesford ahesford left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a link the upstream issue you opened to document this problem and seek a resolution at the source.

Comment thread srcpkgs/wlclock/template Outdated
@orahcio

orahcio commented Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

Please provide a link the upstream issue you opened to document this problem and seek a resolution at the source.

Hi @ahesford. Do you think it is a good idea contact the upstream? The original patch was submitted on FreeBSD on August 2024 and the last upstream change was four years ago. I can send an email to him, but I think FreeBSD staff did it two years ago.

Patch file provided as asked.

@ahesford

Copy link
Copy Markdown
Member

The upstream origin should know about this issue and be asked to find a solution that works on more than glibc. We shouldn't be inventing our own bug fixes.

@orahcio

orahcio commented Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

@ahesford, Yes it is the ideal, I'll send an email. For now, we can merge the patch or we need to wait the upstream to fix that issue?

@ahesford

Copy link
Copy Markdown
Member

We can carry the patch. Should this be musl-only? I don't know the significance of optind with glibc.

@orahcio

orahcio commented Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

I think this patch has no effect on glibc systems. But this issue affect just non glibc, because this the solution originally was purposed on a BSD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants