Skip to content

refactor(config): rename VITE_GIT_HOOKS to VP_GIT_HOOKS - #2195

Open
dennybiasiolli wants to merge 1 commit into
voidzero-dev:mainfrom
dennybiasiolli:fix/2161-vp-git-hooks-rename
Open

refactor(config): rename VITE_GIT_HOOKS to VP_GIT_HOOKS#2195
dennybiasiolli wants to merge 1 commit into
voidzero-dev:mainfrom
dennybiasiolli:fix/2161-vp-git-hooks-rename

Conversation

@dennybiasiolli

Copy link
Copy Markdown

Rename the Git hooks disable env var from VITE_GIT_HOOKS to VP_GIT_HOOKS.

Git hooks are a Vite+ feature, not Vite app config. The VITE_* prefix is reserved for custom env vars exposed to the application, so using it here is confusing (#2161).

  • Canonical name is now VP_GIT_HOOKS
  • VITE_GIT_HOOKS remains accepted as a deprecated alias (install skip, generated hook scripts, help)
  • Docs, RFC notes, unit tests, and CLI help snapshots updated accordingly

Closes #2161

@netlify

netlify Bot commented Jul 17, 2026

Copy link
Copy Markdown

Deploy Preview for viteplus-preview ready!

Name Link
🔨 Latest commit 18b7b69
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/6a6c638e888e290008b9905b
😎 Deploy Preview https://deploy-preview-2195--viteplus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@wan9chi
wan9chi requested a review from fengmk2 July 20, 2026 08:22
@fengmk2 fengmk2 self-assigned this Jul 31, 2026
@fengmk2

fengmk2 commented Jul 31, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5a70ffac48

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/guide/commit-hooks.md Outdated
@jong-kyung

jong-kyung commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

@fengmk2, could you please check #2206 when you have a time?

Comment thread docs/guide/troubleshooting.md Outdated
Git hooks are a Vite+ feature, not Vite app config. The VITE_* prefix is
reserved for custom env vars exposed to the application (voidzero-dev#2161).

- Canonical name is now VP_GIT_HOOKS
- VITE_GIT_HOOKS remains accepted as a deprecated runtime alias
- Docs and CLI help only document VP_GIT_HOOKS

Closes voidzero-dev#2161
@dennybiasiolli
dennybiasiolli force-pushed the fix/2161-vp-git-hooks-rename branch from 5a70ffa to 18b7b69 Compare July 31, 2026 08:57
@dennybiasiolli

Copy link
Copy Markdown
Author

Comments resolved and squashed in a single commit, and also rebased the branch/PR on top of the current main.
Let me know if I have to change something else

@fengmk2 fengmk2 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dennybiasiolli Thanks!

@fengmk2 fengmk2 changed the title fix(config): rename VITE_GIT_HOOKS to VP_GIT_HOOKS refactor(config): rename VITE_GIT_HOOKS to VP_GIT_HOOKS Jul 31, 2026
@dennybiasiolli

Copy link
Copy Markdown
Author

@fengmk2 I can also reword my commit message from fix(config): rename VITE_GIT_HOOKS to VP_GIT_HOOKS to refactor(config): rename VITE_GIT_HOOKS to VP_GIT_HOOKS if you like. Not doing that now to avoid re-launching the CI again

@fengmk2

fengmk2 commented Jul 31, 2026

Copy link
Copy Markdown
Member

@fengmk2 I can also reword my commit message from fix(config): rename VITE_GIT_HOOKS to VP_GIT_HOOKS to refactor(config): rename VITE_GIT_HOOKS to VP_GIT_HOOKS if you like. Not doing that now to avoid re-launching the CI again

No need to change anything, I'll adjust it when I merge😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename VITE_GIT_HOOKS to VP_GIT_HOOKS

3 participants