feat: add support for .nvmrc as node version source - #2244
Conversation
✅ Deploy Preview for viteplus-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
f1637cb to
4e13b0b
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 02d8536af5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
thanks @TheAlexLichter for acting on the review, I saw it and was going to act on it but forgot to do so |
Glad I could help 😋 |
things look fine, I just want this to get merged and released soon so I can stop using my local build of vite-plus 😄 |
be07db4 to
a942cc4
Compare
|
@BlankParticle Thank you for your contribution, I will merge it and release it on Tuesday. |
fixes #2207
adds
.nvmrcas a supported source for node version resolution, behaviour is as discussed in the issueimplemented after discussion with @TheAlexLichter on voidzero discord (#2207 (comment))
thanks to @devmcclu who did a parallel implementation in #2213, i took some tests from that PR