Skip to content

fix(studio): sanitize Hermes proxy asset URLs - #835

Open
zakahan wants to merge 1 commit into
volcengine:mainfrom
zakahan:fix/hermes-webui-gateway-query
Open

fix(studio): sanitize Hermes proxy asset URLs#835
zakahan wants to merge 1 commit into
volcengine:mainfrom
zakahan:fix/hermes-webui-gateway-query

Conversation

@zakahan

@zakahan zakahan commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • remove private faasInstanceName and Authorization query parameters from Hermes WebUI asset URLs exposed through the Studio proxy
  • preserve non-sensitive query parameters and keep the change scoped to Hermes WebUI
  • add regression coverage for root-relative and relative Hermes asset URLs

Validation

  • uv run pre-commit run --all-files
  • uv run --no-sync --with pytest python -m pytest tests/cli/test_frontend_agent_proxy.py tests/cli/test_frontend_sandbox.py (39 passed)
  • verified against a live Hermes Session HTML response: both private query keys drop from 53 occurrences to 0 after rewriting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant