Skip to content

Provide min/max/sum info from zone maps if possible - #9040

Open
myrrc wants to merge 1 commit into
developfrom
zonemap-stats-layout
Open

Provide min/max/sum info from zone maps if possible#9040
myrrc wants to merge 1 commit into
developfrom
zonemap-stats-layout

Conversation

@myrrc

@myrrc myrrc commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

For Zoned layout reader, provide info for min/max/sum functions
directly from zone maps if zone maps are included fully.
Decode data for chunks if some zone maps arent't included fully

(Stack for zone maps aggregation short-circuit)

@myrrc myrrc added the changelog/feature A new feature label Jul 28, 2026
@myrrc
myrrc requested a review from joseph-isaacs July 28, 2026 17:38
Base automatically changed from myrrc/zonemap-aggregate-stats to develop July 29, 2026 08:43
@myrrc
myrrc force-pushed the zonemap-stats-layout branch from f4686ae to 4c70126 Compare July 29, 2026 08:43
@joseph-isaacs

Copy link
Copy Markdown
Contributor

What is the intended semantics of this change/expression. Would you expect this to work over both a layout-reader plan and an array?

@myrrc
myrrc force-pushed the zonemap-stats-layout branch 2 times, most recently from 55619ee to 9e871d6 Compare July 29, 2026 11:22
@codspeed-hq

codspeed-hq Bot commented Jul 29, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 1841 untouched benchmarks
⏩ 55 skipped benchmarks1


Comparing zonemap-stats-layout (fc3bebf) with develop (ab4ab65)2

Open in CodSpeed

Footnotes

  1. 55 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on develop (f3d6795) during the generation of this report, so ab4ab65 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@myrrc
myrrc force-pushed the zonemap-stats-layout branch 4 times, most recently from 55619ee to 06dc827 Compare July 29, 2026 15:01
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@myrrc
myrrc force-pushed the zonemap-stats-layout branch from 06dc827 to fc3bebf Compare July 29, 2026 15:20
@myrrc
myrrc requested a review from robert3005 July 29, 2026 15:50
@myrrc

myrrc commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

Things need to be checked via talking with @robert3005 and @joseph-isaacs

  1. Are zone maps storing exact values? For aggregate vtable, there is "satisfy" which can be used to check this.
  2. String stats are truncated. How does this work vs. non-zone map aggregation?
  3. How will stat function semantics change from "upper bound" to "exact" reflect its users?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants