benchmarks: add string compression benchmark - #9060
Draft
gargiulofrancesco wants to merge 2 commits into
Draft
Conversation
Comment on lines
+17
to
+37
| #[cfg(feature = "unstable_encodings")] | ||
| use string_bench::SerializedResult; | ||
| use string_bench::StringColumn; | ||
| use string_bench::StringEncoder; | ||
| use string_bench::bench_column; | ||
| #[cfg(feature = "unstable_encodings")] | ||
| use string_bench::bench_serialized_with_session; | ||
| use string_bench::load_clickbench_url; | ||
| use string_bench::load_tpch_l_comment; | ||
| use tabled::builder::Builder; | ||
| use tabled::settings::Style; | ||
| #[cfg(feature = "unstable_encodings")] | ||
| use vortex::VortexSessionDefault; | ||
| use vortex::array::VortexSessionExecute; | ||
| #[cfg(feature = "unstable_encodings")] | ||
| use vortex::io::runtime::BlockingRuntime; | ||
| #[cfg(feature = "unstable_encodings")] | ||
| use vortex::io::runtime::current::CurrentThreadRuntime; | ||
| #[cfg(feature = "unstable_encodings")] | ||
| use vortex::io::session::RuntimeSessionExt; | ||
| #[cfg(feature = "unstable_encodings")] |
Contributor
There was a problem hiding this comment.
where did all the unstable encodings cfg come from?
| let run_codec = matches!(args.suite, BenchmarkSuite::Codec | BenchmarkSuite::Both); | ||
| let run_vortex = matches!(args.suite, BenchmarkSuite::Vortex | BenchmarkSuite::Both); | ||
|
|
||
| #[cfg(not(feature = "unstable_encodings"))] |
Contributor
There was a problem hiding this comment.
use unstable encodings only
Contributor
|
Looks reasonable |
Comment on lines
+165
to
+172
| let mut columns: Vec<StringColumn> = Vec::new(); | ||
| if matches("URL") { | ||
| columns.push(load_clickbench_url(args.clickbench_shard, &mut ctx).await?); | ||
| } | ||
| if matches("l_comment") { | ||
| columns.push(load_tpch_l_comment(&mut ctx).await?); | ||
| } | ||
| if columns.is_empty() { |
Contributor
There was a problem hiding this comment.
this this easy to extend with a type vec of columns you filter on maybe a trait would help, look at bench compress
gargiulofrancesco
added
changelog/chore
Signed-off-by: Francesco Gargiulo <gargiulo.fr@gmail.com>
Signed-off-by: Francesco Gargiulo <gargiulo.fr@gmail.com>
gargiulofrancesco
force-pushed
the
fg/string-bench
branch
from
July 29, 2026 16:02
e20260e to
5378034
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This adds a benchmark for evaluating Vortex string encoders on representative datasets.
What changes are included in this PR?
Adds two benchmark suites for evaluating Vortex string encoders:
codec: Direct codec behavior when compressing an entire column.vortex: End-to-end Vortex behavior when writing, opening, scanning, and canonicalizing an in-memory file.What APIs are changed? Are there any user-facing changes?
No production Vortex APIs are changed. This PR adds the new
string-benchCLI.