Skip to content

Reduce concurrency during cmake c++ build to avoid ooms - #9870

Closed
robert3005 wants to merge 1 commit into
developfrom
rk/c++flakes
Closed

robert3005 wants to merge 1 commit into
developfrom
rk/c++flakes

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

We are reaching 95% memory usage and getting oomkilled

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 added the changelog/chore A trivial change label Sep 14, 2026
@robert3005
robert3005 requested a review from 0ax1 September 14, 2026 15:57

@AdamGS AdamGS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@robert3005
robert3005 requested a review from myrrc September 14, 2026 15:57
@robert3005

Copy link
Copy Markdown
Contributor Author

going to make sure that the build succeeds before merging this

@0ax1

0ax1 commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

2 is very low? @robert3005

@0ax1

0ax1 commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Does it oom bc of compiling or linking? Quite often memory usage spikes during linking.

@codspeed

codspeed Bot commented Sep 14, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 6.12%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 2 improved benchmarks
❌ 1 regressed benchmark
✅ 2194 untouched benchmarks
⏩ 218 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime arrow_checked_add_u32_neon[16384] 12.3 µs 20.3 µs -39.61%
WallTime arrow_checked_add_u32_avx2[16384] 21.3 µs 17.6 µs +20.77%
Simulation allocate_drop_arrow[0] 456.9 ns 402.7 ns +13.45%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/c++flakes (8b25b38) with develop (8f3dfb4)

Open in CodSpeed

Footnotes

  1. 218 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@robert3005

Copy link
Copy Markdown
Contributor Author

it's linking

@0ax1

0ax1 commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Superseded by: #9872. Additionally, we will intro a shared lib artefact to reduce the mem footprint during linking. In that PR, we can turn the debug info level back to 2.

@0ax1 0ax1 closed this Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants