Skip to content

Remove unnecessary slicing from RowFn execute_all_constant - #9874

Merged
connortsui20 merged 1 commit into
developfrom
rk/necessary
Sep 14, 2026
Merged

connortsui20 merged 1 commit into
developfrom
rk/necessary

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

this seems entirely unnecessary

Signed-off-by: Robert Kruszewski <github@robertk.io>
@codspeed

codspeed Bot commented Sep 14, 2026

Copy link
Copy Markdown

Merging this PR will regress 3 benchmarks

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 5 improved benchmarks
❌ 3 regressed benchmarks
✅ 2190 untouched benchmarks
⏩ 218 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime dict_canonicalize_gt_u8_avx2[16000000] 7.6 ms 9.7 ms -21.89%
WallTime filtered_owned_i64_avx2[OneNullInEight] 22.2 µs 27.4 µs -18.73%
Simulation random_i16[0.8] 78.4 µs 95.3 µs -17.73%
Simulation random_i16[0.95] 99 µs 80 µs +23.73%
WallTime arrow_checked_add_u32_avx2[16384] 21.4 µs 17.7 µs +21.09%
WallTime words_gather_scalar_avx2[65536] 9.4 µs 8.2 µs +13.74%
Simulation allocate_drop_arrow[0] 456.9 ns 402.7 ns +13.45%
Simulation allocate_drop_bytes[0] 575.7 ns 521.6 ns +10.39%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/necessary (1f6bdba) with develop (7286721)

Open in CodSpeed

Footnotes

  1. 218 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@connortsui20
connortsui20 merged commit 6465462 into develop Sep 14, 2026
98 of 101 checks passed
@connortsui20
connortsui20 deleted the rk/necessary branch September 14, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants