ZSTDArray::append_to_builder falls back to canonical for non utf8/binary dtypes - #9897
Conversation
…ary dtypes Signed-off-by: Robert Kruszewski <github@robertk.io>
Merging this PR will regress 2 benchmarks
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | WallTime | arrow_checked_add_u32_neon[16384] |
13.5 µs | 20.3 µs | -33.5% |
| ❌ | Simulation | random_i8[0.5] |
70.4 µs | 93.9 µs | -25.05% |
| ⚡ | Simulation | random_i16[0.95] |
97.7 µs | 79.5 µs | +22.97% |
| ⚡ | Simulation | decompress[u64, (4000, 1024)] |
86.4 µs | 71 µs | +21.74% |
| ⚡ | WallTime | arrow_checked_add_u32_avx2[16384] |
21.4 µs | 17.7 µs | +21.23% |
| ⚡ | Simulation | allocate_drop_arrow[0] |
456.9 ns | 402.7 ns | +13.45% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing rk/zstdbuilder (2b8d3e1) with develop (c4561ac)
Footnotes
-
218 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
This was an omission from previous pr