Skip to content

ZSTDArray::append_to_builder falls back to canonical for non utf8/binary dtypes - #9897

Merged
robert3005 merged 3 commits into
developfrom
rk/zstdbuilder
Sep 16, 2026
Merged

robert3005 merged 3 commits into
developfrom
rk/zstdbuilder

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

This was an omission from previous pr

…ary dtypes

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 added the changelog/fix A bug fix label Sep 15, 2026
@codspeed

codspeed Bot commented Sep 15, 2026

Copy link
Copy Markdown

Merging this PR will regress 2 benchmarks

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 4 improved benchmarks
❌ 2 regressed benchmarks
✅ 2196 untouched benchmarks
⏩ 218 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime arrow_checked_add_u32_neon[16384] 13.5 µs 20.3 µs -33.5%
Simulation random_i8[0.5] 70.4 µs 93.9 µs -25.05%
Simulation random_i16[0.95] 97.7 µs 79.5 µs +22.97%
Simulation decompress[u64, (4000, 1024)] 86.4 µs 71 µs +21.74%
WallTime arrow_checked_add_u32_avx2[16384] 21.4 µs 17.7 µs +21.23%
Simulation allocate_drop_arrow[0] 456.9 ns 402.7 ns +13.45%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/zstdbuilder (2b8d3e1) with develop (c4561ac)

Open in CodSpeed

Footnotes

  1. 218 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005
robert3005 enabled auto-merge (squash) September 16, 2026 02:29
@robert3005
robert3005 merged commit d5e2856 into develop Sep 16, 2026
80 of 81 checks passed
@robert3005
robert3005 deleted the rk/zstdbuilder branch September 16, 2026 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants