Skip to content

Develop correctly runs tests even if duckdb job is skipped #9898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robert3005 wants to merge 1 commit into
base: develop
Choose a base branch
from
+11 −1
Open

Develop correctly runs tests even if duckdb job is skipped #9898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,8 @@ jobs:
rust-docs:
name: "Rust (docs)"
needs: duckdb-ready
# The PR-only mirror is a skipped ancestor on develop; override implicit success().
if: ${{ !cancelled() && needs.duckdb-ready.result == 'success' }}
timeout-minutes: 30
runs-on: >-
${{ github.repository == 'vortex-data/vortex'
Expand Down Expand Up @@ -398,6 +400,7 @@ jobs:
rust-lint:
name: "Rust (lint)"
needs: duckdb-ready
if: ${{ !cancelled() && needs.duckdb-ready.result == 'success' }}
timeout-minutes: 30
runs-on: >-
${{ github.repository == 'vortex-data/vortex'
Expand Down Expand Up @@ -503,6 +506,7 @@ jobs:
rust-test-windows:
name: "Rust tests (windows-x64)"
needs: duckdb-ready
if: ${{ !cancelled() && needs.duckdb-ready.result == 'success' }}
timeout-minutes: 30
runs-on: >-
${{ github.repository == 'vortex-data/vortex'
Expand Down Expand Up @@ -548,7 +552,9 @@ jobs:
rust-test-linux-arm64:
name: "Rust tests (linux-arm64)"
needs: duckdb-ready
if: github.repository == 'vortex-data/vortex'
if: >-
!cancelled() && needs.duckdb-ready.result == 'success' &&
github.repository == 'vortex-data/vortex'
timeout-minutes: 30
runs-on: runs-on=${{ github.run_id }}/runner=arm64-medium/image=ubuntu24-full-arm64-pre-v2/extras=s3-cache/tag=rust-test-linux-arm64
steps:
Expand Down Expand Up @@ -715,6 +721,7 @@ jobs:
sqllogic-test:
name: "SQL logic tests"
needs: duckdb-ready
if: ${{ !cancelled() && needs.duckdb-ready.result == 'success' }}
runs-on: >-
${{ github.repository == 'vortex-data/vortex'
&& format('runs-on={0}/runner=amd64-ci-medium/image=ubuntu24-full-x64-pre-v2/extras=s3-cache/tag=sql-logic-test', github.run_id)
Expand Down Expand Up @@ -742,6 +749,7 @@ jobs:
duckdb-s3-test:
name: "DuckDB S3 tests"
needs: duckdb-ready
if: ${{ !cancelled() && needs.duckdb-ready.result == 'success' }}
runs-on: >-
${{ github.repository == 'vortex-data/vortex'
&& format('runs-on={0}/runner=amd64-ci-medium/image=ubuntu24-full-x64-pre-v2/extras=s3-cache/tag=duckdb-s3-test', github.run_id)
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/rust-instrumented.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ jobs:
rust-coverage:
name: "Rust tests (coverage) (${{ matrix.suite }})"
needs: duckdb-ready
# The PR-only mirror is a skipped ancestor on develop; override implicit success().
if: ${{ !cancelled() && needs.duckdb-ready.result == 'success' }}
timeout-minutes: 30
permissions:
id-token: write
Expand Down
Loading