Skip to content

[#378] 🤖 - Publish Think answers through the semantic reply boundary - #378

Merged
efraespada merged 2 commits into
developfrom
codex/semantic-think-replies
Sep 15, 2026
Merged

efraespada merged 2 commits into
developfrom
codex/semantic-think-replies

Conversation

@efraespada

@efraespada efraespada commented Sep 15, 2026

Copy link
Copy Markdown
Member

Think now returns an immutable semantic direct answer and leaves GitHub mutation to the shared, source-correlated publisher. Local CLI execution renders the same answer without creating a GitHub comment, and repository messages remain English by default unless another locale is configured.

What changed

  • Removed direct comment writes from Think and reconciled replies by source comment identity.
  • Preserved typed, bounded translation provenance until the final localized renderer.
  • Made --issue optional local context without probing a synthetic issue or requiring a publication target.
  • Added generic BCP-47 catalog resolution with atomic English fallback, sanitization, architecture guards, and regression coverage.

Validation

  • 435 test suites and 3,914 tests pass with all coverage budgets.
  • Typecheck, lint, documentation, workflow, specification, build, package, and installed-package smoke validations pass.
  • GitHub CI, RepoWise, branch sync, commit, and pull-request workflows pass.

Review outcome

Bugbot found one missing-value edge case in local Think. Commit c788fc6 normalizes absent issue context at the CLI and policy boundaries, adds a defensive workflow guard, and resolves the review thread. No findings remain open.

@docs-page

docs-page Bot commented Sep 15, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~378

Documentation is deployed and generated using docs.page

@vypbot vypbot changed the title Publish Think answers through the semantic reply boundary [#378] 🤖 - Publish Think answers through the semantic reply boundary Sep 15, 2026
@vypbot
vypbot self-requested a review September 15, 2026 00:23
@vypbot vypbot added this to vypdev Sep 15, 2026
@vypbot vypbot moved this to In Progress in vypdev Sep 15, 2026
@vypbot
vypbot changed the base branch from develop to master September 15, 2026 00:23
@vypbot
vypbot changed the base branch from master to develop September 15, 2026 00:24
@codecov-commenter

codecov-commenter commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.73684% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.68%. Comparing base (274db40) to head (c788fc6).
⚠️ Report is 739 commits behind head on develop.

Files with missing lines Patch % Lines
src/actions/local_action_output.ts 94.11% 1 Missing and 1 partial ⚠️
...tion/usecases/steps/common/think_request_policy.ts 85.71% 0 Missing and 2 partials ⚠️
src/actions/local_action.ts 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #378      +/-   ##
===========================================
+ Coverage    90.94%   92.68%   +1.73%     
===========================================
  Files          135      647     +512     
  Lines         6251    16826   +10575     
  Branches      1338     4301    +2963     
===========================================
+ Hits          5685    15595    +9910     
- Misses         172      483     +311     
- Partials       394      748     +354     
Files with missing lines Coverage Δ
...application/policies/comment_translation_policy.ts 100.00% <100.00%> (ø)
...pplication/policies/publication_message_catalog.ts 100.00% <100.00%> (ø)
...ion/policies/semantic_result_publication_policy.ts 98.31% <100.00%> (ø)
...ion/usecases/steps/common/think_answer_workflow.ts 100.00% <100.00%> (ø)
...pplication/usecases/steps/common/think_use_case.ts 100.00% <ø> (ø)
...pplication/usecases/steps/common/think_workflow.ts 100.00% <100.00%> (ø)
src/cli/commands/think.ts 100.00% <ø> (ø)
src/cli/commands/think_command_handler.ts 88.23% <100.00%> (ø)
src/domain/message_catalog.ts 100.00% <ø> (ø)
...cture/composition/local_action_composition_root.ts 100.00% <100.00%> (ø)
... and 4 more

... and 695 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vypbot
vypbot changed the base branch from develop to master September 15, 2026 00:43
@vypbot
vypbot changed the base branch from master to develop September 15, 2026 00:44

@vypbot vypbot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current status: Overall coverage is partial; this snapshot does not prove that all of its findings are resolved.
Last reconciled on c788fc6. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 1 potential problem when commit 30124ea was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.

Findings

  • medium: Local Think without --issue still performs an invalid issue lookup — src/application/usecases/steps/common/think_request_policy.ts:78

Comment thread src/application/usecases/steps/common/think_request_policy.ts Outdated
@vypbot

vypbot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Bugbot: review incomplete

Current status: The review of c788fc6 has partial coverage and cannot declare the whole pull request clean.

Action: Inspect the omitted items or reduce the pull request scope. Rerun the review only after changing the scope, limits, or access.

Incomplete coverage
  • selection: complete; retained=1
  • issue-comments: complete; retained=3
  • pull-request-comments: complete; retained=1
  • review-threads: complete; retained=1
  • diff: partial; retained=21, omitted=17, truncated=1
  • previous-findings: complete; retained=1
  • human-conversation: partial; retained=1, truncated=1
  • rules: complete; retained=0

Pull request · Verified commit · Workflow run

@efraespada
efraespada merged commit 3bb7453 into develop Sep 15, 2026
18 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants