Skip to content

Streamline pull request enrichment UX - #379

Merged
efraespada merged 6 commits into
developfrom
codex/pr-enrichment-ux
Sep 15, 2026
Merged

efraespada merged 6 commits into
developfrom
codex/pr-enrichment-ux

Conversation

@efraespada

@efraespada efraespada commented Sep 15, 2026

Copy link
Copy Markdown
Member

This pull request streamlines pull-request enrichment by separating review-state and merge-queue handling from normal analysis, hardening workflow contracts and concurrency, and making generated descriptions concise and evidence-based. It also preserves unlinked pull-request titles and synchronizes the changes across setup templates, documentation, specifications, and generated bundles.

What changed

  • Separated normal pull-request analysis, review-state processing, and merge-queue required checks into distinct workflows with isolated concurrency and fixed check identities.
  • Strengthened workflow-contract validation for event triggers, repository gating, concurrency ownership, merge-queue checks, and review-state behavior.
  • Updated pull-request description generation to return a compact structured response with localized headings, evidence-based validation, optional review notes, and explicit issue-closing status.
  • Preserved pull-request titles when no issue is linked and synchronized the changes across source, setup templates, generated bundles, documentation, and specifications.

Validation

  • Focused Jest and workflow-contract tests were added or updated in the diff; execution results were not available in the workspace evidence.

Review notes

  • The normal PR workflow no longer handles pull_request edited events; review-state events run through the dedicated review-state workflow.
  • The merge-queue workflow intentionally publishes the existing required check as a lightweight compatibility check because constituent PR analysis already ran.

@docs-page

docs-page Bot commented Sep 15, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~379

Documentation is deployed and generated using docs.page

@vypbot
vypbot self-requested a review September 15, 2026 01:51
@vypbot vypbot added this to vypdev Sep 15, 2026
@vypbot vypbot moved this to In Progress in vypdev Sep 15, 2026
@codecov-commenter

codecov-commenter commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.72%. Comparing base (274db40) to head (37164b5).
⚠️ Report is 742 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #379      +/-   ##
===========================================
+ Coverage    90.94%   92.72%   +1.78%     
===========================================
  Files          135      648     +513     
  Lines         6251    16917   +10666     
  Branches      1338     4331    +2993     
===========================================
+ Hits          5685    15687   +10002     
- Misses         172      483     +311     
- Partials       394      747     +353     
Files with missing lines Coverage Δ
src/actions/common_action.ts 98.07% <100.00%> (-0.48%) ⬇️
src/application/policies/agent_response_schemas.ts 100.00% <ø> (ø)
...olicies/pull_request_description_content_policy.ts 100.00% <100.00%> (ø)
...secases/execution/execution_issue_number_policy.ts 100.00% <100.00%> (ø)
...ion/usecases/execution/setup_execution_workflow.ts 96.42% <100.00%> (ø)
...ion/usecases/steps/common/update_title_workflow.ts 100.00% <100.00%> (ø)
.../steps/issue/close_issue_after_merging_use_case.ts 100.00% <100.00%> (ø)
...s/pull_request/link_pull_request_issue_workflow.ts 100.00% <100.00%> (ø)
...e_and_progress_labels_from_issue_to_pr_use_case.ts 100.00% <100.00%> (ø)
...equest/update_pull_request_description_workflow.ts 100.00% <100.00%> (ø)
... and 2 more

... and 698 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vypbot vypbot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current status: Overall coverage is partial; this snapshot does not prove that all of its findings are resolved.
Last reconciled on 37164b5. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 1 potential problem when commit 79da4ff was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.

Findings

  • medium: Review-state events can cancel the active PR analysis — .github/workflows/copilot_pull_request.yml:34

Comment thread .github/workflows/copilot_pull_request.yml
@vypbot

vypbot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Bugbot: review incomplete

Current status: The review of 37164b5 has partial coverage and cannot declare the whole pull request clean.

Action: Inspect the omitted items or reduce the pull request scope. Rerun the review only after changing the scope, limits, or access.

Incomplete coverage
  • selection: complete; retained=1
  • pull-request-comments: complete; retained=1
  • review-threads: complete; retained=1
  • diff: partial; retained=16, omitted=35, truncated=1
  • previous-findings: complete; retained=0
  • human-conversation: complete; retained=0
  • rules: complete; retained=0

Pull request · Verified commit · Workflow run

@efraespada
efraespada merged commit 7e02ef4 into develop Sep 15, 2026
7 checks passed
@efraespada
efraespada deleted the codex/pr-enrichment-ux branch September 15, 2026 02:38
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants