Localize inactivity closure UX - #380
Merged
Merged
Conversation
|
To preview the documentation for this pull request, visit the following URL:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #380 +/- ##
===========================================
+ Coverage 90.94% 92.74% +1.79%
===========================================
Files 135 650 +515
Lines 6251 16950 +10699
Branches 1338 4332 +2994
===========================================
+ Hits 5685 15720 +10035
- Misses 172 483 +311
- Partials 394 747 +353
🚀 New features to boost your workflow:
|
vypbot
reviewed
Sep 15, 2026
Contributor
There was a problem hiding this comment.
Current status: All findings originating in this review are resolved.
Last reconciled oned840c0. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 1 potential problem when commit fc17ee5 was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.
Findings
- high: Spanish inactivity catalog is rejected by catalog validation —
src/application/policies/inactivity_message_catalog.ts:61
Contributor
Bugbot: review complete
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inactivity closure now uses locale-aware, bounded message catalogs for terminal issue explanations and Job Summary results. It also distinguishes revalidation, close, and explanation-publication failures so a confirmed close is not misreported or retried when only its comment fails.
What changed
Validation
Review notes
en-USandes-EScatalogs use one bounded catalog-localization request per distinct effective locale and fall back completely to English if unavailable or invalid.