Skip to content

Localize inactivity closure UX - #380

Merged
efraespada merged 2 commits into
developfrom
codex/inactivity-localization
Sep 15, 2026
Merged

efraespada merged 2 commits into
developfrom
codex/inactivity-localization

Conversation

@efraespada

@efraespada efraespada commented Sep 15, 2026

Copy link
Copy Markdown
Member

Inactivity closure now uses locale-aware, bounded message catalogs for terminal issue explanations and Job Summary results. It also distinguishes revalidation, close, and explanation-publication failures so a confirmed close is not misreported or retried when only its comment fails.

What changed

  • Replaced hard-coded inactivity English/Spanish branches with reviewed catalogs, dynamic localization for other valid BCP-47 locales, and atomic English fallback.
  • Added one semantic terminal explanation per successful closure with locale-aware plural summaries while preserving stable ownership markers and machine-readable payload keys.
  • Separated revalidation, closure, and comment-publication outcomes; recorded commented, commentFailures, and failures counts and retained confirmed closures after partial publication failures.
  • Wired repository and issue locale context plus agent configuration into the inactivity action, and updated documentation, specifications, coverage budgets, and generated bundles.

Validation

  • Exact-head CI passed on Node 24, including 438 suites and 3,986 tests with all coverage budgets satisfied.
  • Build, typecheck, lint, package smoke, documentation, workflow, and specification validation passed.

Review notes

  • If explanation publication fails after a successful close, the result is non-retryable and directs manual comment recovery only when the missing context matters.
  • Locales other than the bundled en-US and es-ES catalogs use one bounded catalog-localization request per distinct effective locale and fall back completely to English if unavailable or invalid.

@docs-page

docs-page Bot commented Sep 15, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~380

Documentation is deployed and generated using docs.page

@vypbot
vypbot self-requested a review September 15, 2026 02:54
@vypbot vypbot added this to vypdev Sep 15, 2026
@vypbot vypbot moved this to In Progress in vypdev Sep 15, 2026
@codecov-commenter

codecov-commenter commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.74%. Comparing base (274db40) to head (ed840c0).
⚠️ Report is 749 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #380      +/-   ##
===========================================
+ Coverage    90.94%   92.74%   +1.79%     
===========================================
  Files          135      650     +515     
  Lines         6251    16950   +10699     
  Branches      1338     4332    +2994     
===========================================
+ Hits          5685    15720   +10035     
- Misses         172      483     +311     
- Partials       394      747     +353     
Files with missing lines Coverage Δ
...application/policies/inactivity_message_catalog.ts 100.00% <100.00%> (ø)
...ication/policies/inactivity_notification_policy.ts 100.00% <100.00%> (ø)
...usecases/actions/close_inactive_issues_use_case.ts 100.00% <100.00%> (ø)
...usecases/actions/close_inactive_issues_workflow.ts 100.00% <100.00%> (ø)
...pplication/usecases/push_single_action_contexts.ts 98.90% <100.00%> (ø)
...e/composition/issue_inactivity_composition_root.ts 100.00% <100.00%> (ø)
...ure/composition/main_run_route_composition_root.ts 93.22% <ø> (ø)

... and 705 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vypbot vypbot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current status: All findings originating in this review are resolved.
Last reconciled on ed840c0. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 1 potential problem when commit fc17ee5 was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.

Findings

  • high: Spanish inactivity catalog is rejected by catalog validation — src/application/policies/inactivity_message_catalog.ts:61

Comment thread src/application/policies/inactivity_message_catalog.ts
@vypbot

vypbot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on ed840c0.

Pull request · Verified commit · Workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants