Skip to content

Localize semantic error presentation - #382

Merged
efraespada merged 1 commit into
developfrom
codex/localized-error-presentation
Sep 15, 2026
Merged

efraespada merged 1 commit into
developfrom
codex/localized-error-presentation

Conversation

@efraespada

@efraespada efraespada commented Sep 15, 2026

Copy link
Copy Markdown
Member

Semantic application errors now use validated recovery descriptors and centralized locale-aware catalogs, so GitHub Action and local CLI failures present consistent English or Spanish guidance while preserving stable codes and references. Error publication is consolidated at the completion boundaries and generated artifacts and documentation are updated accordingly.

What changed

  • Added typed, validated recovery descriptors for partial pull request linking, managed branch enrichment, and inactivity explanation failures.
  • Centralized application error labels and recovery text in versioned English and Spanish message catalogs with bounded interpolation variables.
  • Localized terminal and GitHub Action error presentation using the effective repository locale while keeping error codes, correlation references, and machine contracts stable.
  • Consolidated failure handling so workflow and Bugbot errors are rendered once at the appropriate completion boundary, with sanitized semantic messages instead of provider diagnostics.
  • Updated affected workflows, tests, specifications, documentation, and generated bundles for the new error presentation contract.

Review notes

  • Callers constructing ApplicationError must use the typed recovery descriptor; arbitrary impact, action, and retainedState overrides are no longer part of the semantic error options.
  • Review locale-specific output and partial-operation recovery scenarios when validating the updated user-facing behavior.

@docs-page

docs-page Bot commented Sep 15, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~382

Documentation is deployed and generated using docs.page

@vypbot
vypbot self-requested a review September 15, 2026 04:23
@vypbot vypbot added this to vypdev Sep 15, 2026
@vypbot vypbot moved this to In Progress in vypdev Sep 15, 2026
@codecov-commenter

codecov-commenter commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.79%. Comparing base (274db40) to head (bdcd085).
⚠️ Report is 755 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #382      +/-   ##
===========================================
+ Coverage    90.94%   92.79%   +1.84%     
===========================================
  Files          135      651     +516     
  Lines         6251    17039   +10788     
  Branches      1338     4354    +3016     
===========================================
+ Hits          5685    15811   +10126     
- Misses         172      482     +310     
- Partials       394      746     +352     
Files with missing lines Coverage Δ
src/actions/github_action.ts 97.40% <100.00%> (+15.47%) ⬆️
src/actions/github_action_completion.ts 90.99% <100.00%> (ø)
src/actions/local_action_output.ts 95.00% <100.00%> (ø)
src/actions/main_run_lifecycle.ts 98.30% <100.00%> (ø)
src/application/errors/application_error.ts 100.00% <100.00%> (ø)
...ication/policies/action_summary_message_catalog.ts 100.00% <100.00%> (ø)
src/application/policies/action_summary_policy.ts 96.47% <100.00%> (ø)
...tion/policies/application_error_message_catalog.ts 100.00% <100.00%> (ø)
.../policies/application_error_presentation_policy.ts 100.00% <100.00%> (ø)
...application/policies/deployment_message_catalog.ts 100.00% <100.00%> (ø)
... and 8 more

... and 695 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vypbot vypbot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current status: Overall coverage is partial; this snapshot does not prove that all of its findings are resolved.
Last reconciled on bdcd085. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 1 potential problem when commit 84a8d7d was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.

Findings

  • medium: Preserve per-error recovery context — src/application/policies/application_error_presentation_policy.ts:22

Comment thread src/application/policies/application_error_presentation_policy.ts Outdated
@vypbot

vypbot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Bugbot: review incomplete

Current status: The review of bdcd085 has partial coverage and cannot declare the whole pull request clean.

Action: Inspect the omitted items or reduce the pull request scope. Rerun the review only after changing the scope, limits, or access.

Incomplete coverage
  • selection: complete; retained=1
  • pull-request-comments: complete; retained=1
  • review-threads: complete; retained=1
  • diff: partial; retained=22, omitted=20, truncated=1
  • previous-findings: complete; retained=1
  • human-conversation: complete; retained=0
  • rules: complete; retained=0

Pull request · Verified commit · Workflow run

@efraespada
efraespada force-pushed the codex/localized-error-presentation branch from 84a8d7d to bdcd085 Compare September 15, 2026 04:42
@efraespada
efraespada merged commit a4a058c into develop Sep 15, 2026
8 checks passed
@efraespada
efraespada deleted the codex/localized-error-presentation branch September 15, 2026 04:55
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants