Skip to content

Harden localized request and local result UX - #383

Merged
efraespada merged 5 commits into
developfrom
codex/request-publication-cli-ux
Sep 15, 2026
Merged

efraespada merged 5 commits into
developfrom
codex/request-publication-cli-ux

Conversation

@efraespada

@efraespada efraespada commented Sep 15, 2026

Copy link
Copy Markdown
Member

Improves publication safety and clarity across comment automation and local CLI execution. Technical operands are preserved through translation, explicit failures receive bounded semantic replies, and local output reports actionable aggregate results without exposing internal prose.

What changed

  • Protects code, paths, refs, URLs, flags, identifiers, and other technical operands with validated placeholders during language adaptation.
  • Publishes one localized, correlated semantic error reply for explicit request failures while keeping background failures in operational evidence.
  • Updates local CLI output to show localized status and completed, skipped, failed, and reminder counts instead of replaying internal steps or reminder text.
  • Adds shared application-error rendering, command prose classification, catalog messages, documentation, specifications, tests, and regenerated build artifacts for the new behavior.

Review notes

  • Translation output is rejected if protected operands are missing, duplicated, reordered, changed, or newly introduced; invalid output prevents the requested mutation.
  • The message catalog contract advances to version 3, and generated build/ bundles are included with the source changes.

@docs-page

docs-page Bot commented Sep 15, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~383

Documentation is deployed and generated using docs.page

@vypbot
vypbot self-requested a review September 15, 2026 05:20
@vypbot vypbot added this to vypdev Sep 15, 2026
@vypbot vypbot moved this to In Progress in vypdev Sep 15, 2026
@codecov-commenter

codecov-commenter commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.81%. Comparing base (274db40) to head (dbfb0a1).
⚠️ Report is 757 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #383      +/-   ##
===========================================
+ Coverage    90.94%   92.81%   +1.87%     
===========================================
  Files          135      651     +516     
  Lines         6251    17128   +10877     
  Branches      1338     4385    +3047     
===========================================
+ Hits          5685    15898   +10213     
- Misses         172      483     +311     
- Partials       394      747     +353     
Files with missing lines Coverage Δ
src/actions/local_action_output.ts 95.55% <100.00%> (ø)
.../policies/application_error_presentation_policy.ts 100.00% <100.00%> (ø)
...application/policies/comment_translation_policy.ts 100.00% <100.00%> (ø)
...pplication/policies/publication_message_catalog.ts 100.00% <ø> (ø)
...ion/policies/semantic_result_publication_policy.ts 98.50% <100.00%> (ø)
...pplication/usecases/comment_automation_use_case.ts 90.90% <100.00%> (ø)
...ps/common/comment_language_translation_workflow.ts 93.84% <100.00%> (ø)
src/domain/copilot_command.ts 86.95% <100.00%> (ø)
src/domain/message_catalog.ts 100.00% <100.00%> (ø)
src/prompts/check_comment_language.ts 100.00% <ø> (ø)

... and 703 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vypbot vypbot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current status: Overall coverage is partial; this snapshot does not prove that all of its findings are resolved.
Last reconciled on dbfb0a1. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 1 potential problem when commit a0390fd was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.

Findings

  • high: Placeholder validation allows technical operands to be modified — src/application/policies/comment_translation_policy.ts:70

Comment thread src/application/policies/comment_translation_policy.ts Outdated
@vypbot

vypbot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Bugbot: review incomplete

Current status: The review of dbfb0a1 has partial coverage and cannot declare the whole pull request clean.

Action: Inspect the omitted items or reduce the pull request scope. Rerun the review only after changing the scope, limits, or access.

Incomplete coverage
  • selection: complete; retained=1
  • pull-request-comments: complete; retained=2
  • review-threads: complete; retained=2
  • diff: partial; retained=20, omitted=6
  • previous-findings: complete; retained=1
  • human-conversation: complete; retained=0
  • rules: complete; retained=0

Pull request · Verified commit · Workflow run

@vypbot vypbot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current status: Overall coverage is partial; this snapshot does not prove that all of its findings are resolved.
Last reconciled on dbfb0a1. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 1 potential problem when commit 678d3c7 was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.

Findings

  • high: Bare paths and refs are not protected during translation — src/application/policies/comment_translation_policy.ts:32

Comment thread src/application/policies/comment_translation_policy.ts Outdated
@efraespada
efraespada merged commit 50692a4 into develop Sep 15, 2026
9 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants