Skip to content

Guard progress state against stale branch heads - #384

Merged
efraespada merged 1 commit into
developfrom
codex/publication-source-freshness
Sep 15, 2026
Merged

efraespada merged 1 commit into
developfrom
codex/publication-source-freshness

Conversation

@efraespada

@efraespada efraespada commented Sep 15, 2026

Copy link
Copy Markdown
Member

Publication now verifies that generated results still match the authoritative branch head before mutating GitHub. This prevents stale progress and status updates from overwriting newer source state and records skipped work as structured stale-source evidence.

What changed

  • Added an authoritative GitHub branch-head query boundary for publication freshness checks.
  • Added source-head guards to progress results and status publication intents.
  • Revalidated source freshness before status-card creation, updates, and duplicate compaction, returning a stale-source outcome when the branch advances.
  • Propagated stale publication evidence into progress handling and action summaries.
  • Added coverage for repository reads, stale-source outcomes, freshness races, and publication wiring.

Review notes

  • Commit-derived publication now requires an authoritative source query and fails closed when that dependency is unavailable.
  • A stale result is treated as a successful skipped outcome and does not publish or mutate the status card.

@docs-page

docs-page Bot commented Sep 15, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~384

Documentation is deployed and generated using docs.page

@vypbot
vypbot self-requested a review September 15, 2026 06:41
@vypbot vypbot added this to vypdev Sep 15, 2026
@vypbot vypbot moved this to In Progress in vypdev Sep 15, 2026
@codecov-commenter

codecov-commenter commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.07692% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.84%. Comparing base (274db40) to head (1ef7ec4).
⚠️ Report is 763 commits behind head on develop.

Files with missing lines Patch % Lines
...n/usecases/steps/common/publish_resume_workflow.ts 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #384      +/-   ##
===========================================
+ Coverage    90.94%   92.84%   +1.89%     
===========================================
  Files          135      654     +519     
  Lines         6251    17217   +10966     
  Branches      1338     4410    +3072     
===========================================
+ Hits          5685    15985   +10300     
- Misses         172      484     +312     
- Partials       394      748     +354     
Files with missing lines Coverage Δ
src/actions/github_action.ts 97.50% <100.00%> (+15.57%) ⬆️
src/actions/github_action_completion.ts 90.99% <100.00%> (ø)
src/actions/github_event_inputs.ts 100.00% <100.00%> (ø)
...ication/policies/action_summary_message_catalog.ts 100.00% <ø> (ø)
src/application/policies/action_summary_policy.ts 96.59% <100.00%> (ø)
...application/policies/publication_outcome_policy.ts 100.00% <100.00%> (ø)
...ion/policies/semantic_result_publication_policy.ts 98.52% <100.00%> (ø)
...cation/usecases/actions/check_progress_use_case.ts 100.00% <100.00%> (ø)
...cation/usecases/actions/check_progress_workflow.ts 93.47% <100.00%> (ø)
...ion/usecases/actions/progress_analysis_workflow.ts 97.82% <100.00%> (ø)
... and 12 more

... and 694 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vypbot vypbot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current status: Overall coverage is partial; this snapshot does not prove that all of its findings are resolved.
Last reconciled on 1ef7ec4. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 1 potential problem when commit f488daa was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.

Findings

  • medium: Do not use the workflow SHA as the selected progress branch head — src/actions/github_event_inputs.ts:37

Comment thread src/actions/github_event_inputs.ts Outdated
@vypbot

vypbot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Bugbot: review incomplete

Current status: The review of 1ef7ec4 has partial coverage and cannot declare the whole pull request clean.

Action: Inspect the omitted items or reduce the pull request scope. Rerun the review only after changing the scope, limits, or access.

Incomplete coverage
  • selection: complete; retained=1
  • pull-request-comments: complete; retained=2
  • review-threads: complete; retained=1
  • diff: partial; retained=30, omitted=16
  • previous-findings: complete; retained=0
  • human-conversation: complete; retained=1
  • rules: complete; retained=0

Pull request · Verified commit · Workflow run

@efraespada
efraespada force-pushed the codex/publication-source-freshness branch from f2adb6b to 1ef7ec4 Compare September 15, 2026 06:58
@efraespada
efraespada merged commit 4faa5d5 into develop Sep 15, 2026
10 checks passed
@efraespada
efraespada deleted the codex/publication-source-freshness branch September 15, 2026 07:12
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants