Skip to content

Remove exact semantic publication duplicates - #385

Merged
efraespada merged 2 commits into
developfrom
codex/semantic-duplicate-cleanup
Sep 15, 2026
Merged

efraespada merged 2 commits into
developfrom
codex/semantic-duplicate-cleanup

Conversation

@efraespada

@efraespada efraespada commented Sep 15, 2026

Copy link
Copy Markdown
Member

Summary

  • keep the lowest bot-owned exact-identity comment as the canonical publication and delete later semantic duplicates
  • treat GitHub 404 deletion responses as idempotent success, retain a localized compact pointer only for explicit permission-denied 403 responses, and surface rate limits or unknown failures
  • revalidate commit-derived source freshness before every cleanup mutation and restrict delete authority to semantic reconcilers
  • expose bounded localized cleanup debt in the Job Summary, including the total and up to 20 affected comment IDs
  • update the SDD, catalog evidence, architecture inventory, user documentation, coverage budgets, generated bundles, and the narrowed deployment adapter tests

UX contract

Normal successful cleanup leaves one canonical comment and no extra conversation noise. If deletion is forbidden, the duplicate becomes a short localized pointer to the canonical card and the workflow Job Summary explains the retained cleanup debt. Human-authored, third-party, malformed, and legacy comments are never rewritten or removed.

Validation

  • 444 test suites, 4,182 tests passed
  • coverage: 96.26% statements, 91.15% branches, 96.56% functions, 97.36% lines
  • semantic duplicate reconciliation coverage budget passed
  • narrowed deployment presentation adapter: 100% statements, functions, and lines
  • typecheck and lint passed
  • specification, documentation, agent documentation, docs asset, and workflow contracts passed
  • generated bundle validation passed
  • npm package validation and package smoke test passed

@docs-page

docs-page Bot commented Sep 15, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~385

Documentation is deployed and generated using docs.page

@vypbot
vypbot self-requested a review September 15, 2026 07:43
@vypbot vypbot added this to vypdev Sep 15, 2026
@vypbot vypbot moved this to In Progress in vypdev Sep 15, 2026
@codecov-commenter

codecov-commenter commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.93%. Comparing base (274db40) to head (f66ed77).
⚠️ Report is 765 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #385      +/-   ##
===========================================
+ Coverage    90.94%   92.93%   +1.99%     
===========================================
  Files          135      655     +520     
  Lines         6251    17307   +11056     
  Branches      1338     4437    +3099     
===========================================
+ Hits          5685    16085   +10400     
- Misses         172      473     +301     
- Partials       394      749     +355     
Files with missing lines Coverage Δ
...ication/policies/action_summary_message_catalog.ts 100.00% <ø> (ø)
src/application/policies/action_summary_policy.ts 96.90% <100.00%> (ø)
...application/policies/publication_outcome_policy.ts 100.00% <100.00%> (ø)
...usecases/actions/publish_issue_comment_use_case.ts 100.00% <100.00%> (ø)
...usecases/actions/publish_issue_comment_workflow.ts 100.00% <ø> (ø)
...steps/common/duplicate_comment_cleanup_workflow.ts 100.00% <100.00%> (ø)
...n/usecases/steps/common/publish_resume_workflow.ts 94.73% <100.00%> (ø)
...secases/steps/common/reply_publication_workflow.ts 97.36% <100.00%> (ø)
...s/steps/common/status_card_publication_workflow.ts 98.33% <100.00%> (ø)
...y/deployment/deployment_presentation_repository.ts 91.66% <100.00%> (ø)
... and 3 more

... and 704 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vypbot

vypbot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Bugbot: review incomplete

Current status: The review of f66ed77 has partial coverage and cannot declare the whole pull request clean.

Action: Inspect the omitted items or reduce the pull request scope. Rerun the review only after changing the scope, limits, or access.

Incomplete coverage
  • selection: complete; retained=1
  • pull-request-comments: complete; retained=0
  • review-threads: complete; retained=0
  • diff: partial; retained=22, omitted=11
  • previous-findings: complete; retained=0
  • human-conversation: complete; retained=0
  • rules: complete; retained=0

Pull request · Verified commit · Workflow run

@efraespada
efraespada merged commit be9fc30 into develop Sep 15, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants