Skip to content

Add transition notification publication substrate - #386

Merged
efraespada merged 3 commits into
developfrom
codex/actionable-transition-notifications
Sep 15, 2026
Merged

efraespada merged 3 commits into
developfrom
codex/actionable-transition-notifications

Conversation

@efraespada

@efraespada efraespada commented Sep 15, 2026

Copy link
Copy Markdown
Member

Adds a reusable, idempotent transition-notification publication path with strict identity, fingerprint, content, and target validation. It records bounded, content-free outcomes for localized Job Summary reporting and strengthens coverage for duplicate handling and invalid targets.

What changed

  • Added immutable transition markers and fingerprints derived from trusted transition identity and source data, excluding visible message content.
  • Added reconciliation that creates one bot-owned notification per fingerprint, detects concurrent creation, removes or compacts duplicates, and preserves issued copy.
  • Added validation for publication target kinds and numbers, notification length, link count, HTML markers, bot identity, and malformed markers.
  • Added localized action-summary reporting for created and reused notifications, plus updated architecture/specification metadata and generated bundles.
  • Added focused tests covering creation, reuse, duplicate cleanup, visibility lag, forged markers, invalid content, provider failures, and target validation.

Review notes

  • This PR adds the shared notification substrate and does not migrate a feature to use it; branch-sync adoption remains a separate rollout step.

@docs-page

docs-page Bot commented Sep 15, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~386

Documentation is deployed and generated using docs.page

@vypbot
vypbot self-requested a review September 15, 2026 08:33
@vypbot vypbot added this to vypdev Sep 15, 2026
@vypbot vypbot moved this to In Progress in vypdev Sep 15, 2026
@codecov-commenter

codecov-commenter commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.98%. Comparing base (274db40) to head (97f6a12).
⚠️ Report is 768 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #386      +/-   ##
===========================================
+ Coverage    90.94%   92.98%   +2.03%     
===========================================
  Files          135      656     +521     
  Lines         6251    17411   +11160     
  Branches      1338     4471    +3133     
===========================================
+ Hits          5685    16189   +10504     
- Misses         172      473     +301     
- Partials       394      749     +355     
Files with missing lines Coverage Δ
...ication/policies/action_summary_message_catalog.ts 100.00% <ø> (ø)
src/application/policies/action_summary_policy.ts 97.02% <100.00%> (ø)
...pplication/policies/publication_identity_policy.ts 100.00% <100.00%> (ø)
...application/policies/publication_outcome_policy.ts 100.00% <100.00%> (ø)
...s/steps/common/transition_notification_workflow.ts 100.00% <100.00%> (ø)
src/domain/github_publication.ts 100.00% <100.00%> (ø)

... and 712 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vypbot vypbot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current status: All findings originating in this review are resolved.
Last reconciled on 97f6a12. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 1 potential problem when commit 8793745 was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.

Findings

  • low: Failed results can be reported as published notifications — src/application/policies/publication_outcome_policy.ts:120

Comment thread src/application/policies/publication_outcome_policy.ts
@vypbot

vypbot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on 97f6a12.

Pull request · Verified commit · Workflow run

@vypbot vypbot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current status: All findings originating in this review are resolved.
Last reconciled on 97f6a12. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 1 potential problem when commit 87b876b was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.

Findings

  • low: Invalid transition targets can create unreconcilable notifications — src/application/policies/publication_identity_policy.ts:111

Comment thread src/application/policies/publication_identity_policy.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants