Skip to content

Structure implementation plan messages - #389

Merged
efraespada merged 5 commits into
developfrom
codex/structured-implementation-plans
Sep 15, 2026
Merged

efraespada merged 5 commits into
developfrom
codex/structured-implementation-plans

Conversation

@efraespada

@efraespada efraespada commented Sep 15, 2026

Copy link
Copy Markdown
Member

Introduces a structured implementation-plan contract with bounded steps and acceptance criteria. Plans now render consistently, support locale-aware replay and migration, and prevent malformed or mixed-language content from being published.

What changed

  • Added a validated implementation-plan model requiring three to eight ordered steps, up to two details per step, and one bounded acceptance criterion.
  • Updated agent responses, prompts, fingerprints, persistence, and publication rendering to use structured plans instead of arbitrary Markdown.
  • Added locale-aware replay and migration behavior, including fail-closed handling for missing, mismatched, or invalid plan state.
  • Documented the new plan format, localization rules, idempotent updates, and legacy-plan compatibility, with focused contract and workflow tests.

Review notes

  • Legacy free-form plans remain readable, but require an agent-backed structured replacement during the next configured planning run.
  • Changing the effective issue locale requires a complete localized replacement; unchanged responses are rejected until the stored plan locale matches.

@docs-page

docs-page Bot commented Sep 15, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~389

Documentation is deployed and generated using docs.page

@vypbot
vypbot self-requested a review September 15, 2026 11:00
@vypbot vypbot added this to vypdev Sep 15, 2026
@vypbot vypbot moved this to In Progress in vypdev Sep 15, 2026
@codecov-commenter

codecov-commenter commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.06%. Comparing base (274db40) to head (52ffde3).
⚠️ Report is 779 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #389      +/-   ##
===========================================
+ Coverage    90.94%   93.06%   +2.12%     
===========================================
  Files          135      657     +522     
  Lines         6251    17572   +11321     
  Branches      1338     4534    +3196     
===========================================
+ Hits          5685    16354   +10669     
- Misses         172      471     +299     
- Partials       394      747     +353     
Files with missing lines Coverage Δ
src/actions/github_action_completion.ts 95.90% <100.00%> (ø)
src/application/policies/agent_response_schemas.ts 100.00% <ø> (ø)
...pplication/policies/publication_message_catalog.ts 100.00% <ø> (ø)
...ion/policies/semantic_result_publication_policy.ts 98.26% <100.00%> (ø)
.../usecases/actions/recommend_steps_result_policy.ts 100.00% <100.00%> (ø)
...ation/usecases/actions/recommend_steps_workflow.ts 98.11% <100.00%> (ø)
...pplication/usecases/push_single_action_contexts.ts 98.96% <100.00%> (ø)
src/data/model/config.ts 92.85% <100.00%> (-7.15%) ⬇️
src/data/model/recommendation_state.ts 100.00% <100.00%> (ø)
src/domain/implementation_plan.ts 100.00% <100.00%> (ø)
... and 1 more

... and 708 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vypbot

vypbot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Bugbot: review incomplete

Current status: The review of 52ffde3 has partial coverage and cannot declare the whole pull request clean.

Action: Inspect the omitted items or reduce the pull request scope. Rerun the review only after changing the scope, limits, or access.

Incomplete coverage
  • selection: complete; retained=1
  • pull-request-comments: complete; retained=1
  • review-threads: complete; retained=1
  • diff: partial; retained=19, omitted=10, truncated=1
  • previous-findings: complete; retained=1
  • human-conversation: complete; retained=0
  • rules: complete; retained=0

Pull request · Verified commit · Workflow run

@vypbot vypbot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current status: Overall coverage is partial; this snapshot does not prove that all of its findings are resolved.
Last reconciled on 52ffde3. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 1 potential problem when commit 8b8fa00 was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.

Findings

  • medium: Locale changes replay plan content in the previous locale — src/application/usecases/actions/recommend_steps_workflow.ts:60

Comment thread src/application/usecases/actions/recommend_steps_workflow.ts Outdated
@efraespada
efraespada merged commit 46ec198 into develop Sep 15, 2026
9 of 10 checks passed
@efraespada
efraespada deleted the codex/structured-implementation-plans branch September 15, 2026 11:46
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants