Skip to content

Remove legacy locale and translation contracts - #392

Merged
efraespada merged 1 commit into
developfrom
codex/remove-legacy-locale-contracts
Sep 15, 2026
Merged

efraespada merged 1 commit into
developfrom
codex/remove-legacy-locale-contracts

Conversation

@efraespada

@efraespada efraespada commented Sep 15, 2026

Copy link
Copy Markdown
Member

The locale and translation interfaces now enforce the canonical contracts consistently. Legacy locale compatibility paths are removed, reducing ambiguity for callers and keeping localized output behavior predictable.

What changed

  • Enforced strict validation and canonical handling for locale values.
  • Removed legacy locale and translation contract paths and aliases.
  • Aligned locale-dependent flows with the current repository, issue, and pull-request contracts.

Review notes

  • This is a compatibility-cut change: integrations using removed legacy locale contracts must migrate to the canonical interfaces.
  • No separate linked issue is resolved by this pull request.

@docs-page

docs-page Bot commented Sep 15, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~392

Documentation is deployed and generated using docs.page

@vypbot
vypbot self-requested a review September 15, 2026 20:55
@vypbot vypbot added this to vypdev Sep 15, 2026
@vypbot vypbot moved this to In Progress in vypdev Sep 15, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.02%. Comparing base (274db40) to head (2a9ef0a).
⚠️ Report is 791 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #392      +/-   ##
===========================================
+ Coverage    90.94%   93.02%   +2.08%     
===========================================
  Files          135      657     +522     
  Lines         6251    17541   +11290     
  Branches      1338     4509    +3171     
===========================================
+ Hits          5685    16318   +10633     
- Misses         172      473     +301     
- Partials       394      750     +356     
Files with missing lines Coverage Δ
src/actions/github_action_completion.ts 94.26% <100.00%> (ø)
src/application/policies/agent_response_schemas.ts 100.00% <ø> (ø)
...tion/policies/bugbot_review_presentation_policy.ts 100.00% <100.00%> (ø)
...application/policies/comment_translation_policy.ts 100.00% <ø> (ø)
...plication/policies/setup_configuration_defaults.ts 97.67% <ø> (ø)
...plication/policies/setup_doctor_message_catalog.ts 100.00% <ø> (ø)
...application/policies/setup_doctor_report_policy.ts 100.00% <100.00%> (ø)
...ation/services/deployment_orchestration_runtime.ts 88.11% <100.00%> (ø)
src/application/usecases/issue_workflow_context.ts 100.00% <ø> (ø)
...lication/usecases/pull_request_workflow_context.ts 100.00% <ø> (ø)
... and 11 more

... and 698 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vypbot

vypbot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Bugbot: review incomplete

Current status: The review of 2a9ef0a has partial coverage and cannot declare the whole pull request clean.

Action: Inspect the omitted items or reduce the pull request scope. Rerun the review only after changing the scope, limits, or access.

Incomplete coverage
  • selection: complete; retained=1
  • pull-request-comments: complete; retained=0
  • review-threads: complete; retained=0
  • diff: partial; retained=49, omitted=24, truncated=1
  • previous-findings: complete; retained=0
  • human-conversation: complete; retained=0
  • rules: complete; retained=0

Pull request · Verified commit · Workflow run

@efraespada
efraespada merged commit a7ea905 into develop Sep 15, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants