Skip to content

Enforce current-only publication state contracts - #394

Merged
efraespada merged 2 commits into
developfrom
codex/remove-legacy-publication-contracts
Sep 15, 2026
Merged

efraespada merged 2 commits into
developfrom
codex/remove-legacy-publication-contracts

Conversation

@efraespada

@efraespada efraespada commented Sep 15, 2026

Copy link
Copy Markdown
Member

This PR removes legacy publication and persisted-state compatibility paths and tightens the remaining contracts. It also makes partial Bugbot coverage explicitly block pull request readiness until maintainer review.

What changed

  • Removed legacy recommendation text, watermark handling, and compatibility markers in favor of structured publication state.
  • Made persisted recommendation and deployment snapshots strict, including exact fields and required failure evidence for blocked deployments.
  • Updated lifecycle handling so partial Bugbot coverage removes state:ready and applies state:blocked with state:awaiting-maintainer.
  • Updated focused tests, documentation, specifications, and generated bundles to reflect the simplified contracts and partial-review behavior.

@docs-page

docs-page Bot commented Sep 15, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~394

Documentation is deployed and generated using docs.page

@vypbot
vypbot self-requested a review September 15, 2026 22:31
@vypbot vypbot added this to vypdev Sep 15, 2026
@vypbot vypbot moved this to In Progress in vypdev Sep 15, 2026
@vypbot

vypbot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Bugbot: review incomplete

Current status: The review of a26f0c9 has partial coverage and cannot declare the whole pull request clean.

Action: Do not treat this review as complete. Review the sources under Incomplete coverage and manually inspect omitted items; rerun only after reducing the relevant scope or restoring provider access.

Incomplete coverage
  • selection: complete; retained=1
  • pull-request-comments: complete; retained=0
  • review-threads: complete; retained=0
  • diff: partial; retained=26, omitted=50, truncated=2
  • previous-findings: complete; retained=0
  • human-conversation: complete; retained=0
  • rules: complete; retained=0

Pull request · Verified commit · Workflow run

@codecov-commenter

codecov-commenter commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.22222% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.00%. Comparing base (274db40) to head (a26f0c9).
⚠️ Report is 796 commits behind head on develop.

Files with missing lines Patch % Lines
src/data/model/config.ts 57.14% 2 Missing and 1 partial ⚠️
src/actions/github_action_completion.ts 50.00% 0 Missing and 1 partial ⚠️
...ication/policies/deployment_presentation_policy.ts 85.71% 0 Missing and 1 partial ⚠️
...deployment_handlers/continue_deployment_handler.ts 80.00% 0 Missing and 1 partial ⚠️
src/data/model/recommendation_state.ts 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #394      +/-   ##
===========================================
+ Coverage    90.94%   93.00%   +2.05%     
===========================================
  Files          135      651     +516     
  Lines         6251    17462   +11211     
  Branches      1338     4489    +3151     
===========================================
+ Hits          5685    16240   +10555     
- Misses         172      475     +303     
- Partials       394      747     +353     
Files with missing lines Coverage Δ
src/application/policies/agent_response_schemas.ts 100.00% <ø> (ø)
...cation/policies/branch_sync_notification_policy.ts 100.00% <100.00%> (ø)
...application/policies/copilot_interaction_policy.ts 100.00% <ø> (ø)
...lication/policies/deployment_continuation_guard.ts 100.00% <100.00%> (ø)
src/application/policies/lifecycle_state_policy.ts 96.07% <100.00%> (ø)
...pplication/policies/publication_identity_policy.ts 100.00% <ø> (ø)
...pplication/policies/publication_message_catalog.ts 100.00% <ø> (ø)
src/application/policies/recommendation_policy.ts 100.00% <ø> (ø)
...ion/policies/semantic_result_publication_policy.ts 98.24% <100.00%> (ø)
...c/application/policies/setup_configuration_plan.ts 97.85% <ø> (ø)
... and 18 more

... and 690 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Block PR readiness when Bugbot coverage is partial and keep the maintainer waiting state explicit. Suppress greenfield migration notes when repository evidence confirms there are no users or persisted production state, with updated SDDs, tests, docs, and generated bundles.
@efraespada
efraespada merged commit 9873a49 into develop Sep 15, 2026
6 checks passed
@efraespada
efraespada deleted the codex/remove-legacy-publication-contracts branch September 15, 2026 23:05
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants