Skip to content

Add du --time completion option (#403) - #405

Draft
warp-factories[bot] wants to merge 2 commits into
mainfrom
factory/gh403-du-time-spec
Draft

Add du --time completion option (#403)#405
warp-factories[bot] wants to merge 2 commits into
mainfrom
factory/gh403-du-time-spec

Conversation

@warp-factories

@warp-factories warp-factories Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #403.

Adds GNU du's --time option to command-signatures/json/du.json, following the approved spec in specs/GH403/.

  • --time is a single option with an optional WORD argument (isOptional: true), so bare du --time remains valid.
  • du --time= offers the five documented GNU values grouped into two alias suggestions:
    • atime / access / use — last access time
    • ctime / status — last status-change time
  • Modeled on ls.json's --color option (no requiresEquals).
  • No other options, the file/folder argument, schema, or generator code were touched.

Out of scope (per spec, unchanged): --time-style=STYLE, --max-depth (#372), pairing short options with long aliases (#374).

Validation

  • npm run format -- command-signatures/json/du.json — unchanged (already Prettier-formatted).
  • script/presubmit — passed: npm run format:check, cargo fmt --check, cargo clippy --all-targets --all-features -- -D warnings, and the full cargo test suite (176 tests in warp-command-signatures, including all_command_specs_succeed_deserialization, plus 10 in warp-completion-metadata), all green.

@warp-factories

warp-factories Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

This PR was generated with Warp.

Comment @warp-factory on this PR to send it follow-up work.

View run View conversation View GitHub Issue

@vikvang vikvang added the plan-approved Human approval of the spec in this PR; unblocks gated implementation label Sep 8, 2026
@warp-factories

warp-factories Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

Spec approved. This spec is approved for issue #403, and the spec stage is complete.

Implementation is still gated: a maintainer can apply ready-to-implement to issue #403 and assign the factory to start it. This branch and PR are retained — the implementation commits land here.

Responding as Warp for OSS: Open session · View run

Adds the GNU --time option to du.json with an optional WORD
argument, offering the documented atime/access/use (last access
time) and ctime/status (last status-change time) value groups.

Fixes #403
@warp-factories warp-factories Bot changed the title Spec: du completion spec missing the --time long option (#403) Add du --time completion option (#403) Sep 8, 2026

@warp-factories warp-factories Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

Adds GNU du's --time option to command-signatures/json/du.json with an optional WORD argument and the documented value aliases, exactly as the approved GH403 spec prescribes. Net position: accepted.

Notes

  • Correctness was checked against du --help: bare --time shows the last modification time, and the accepted values are exactly atime, access, use, ctime, status. The description and the two alias groups match, and no undocumented value (such as mtime) is suggested.
  • The structure mirrors the --color pattern in ls.json, and the alias arrays expand to one suggestion per spelling via completion-metadata/src/fig_types.rs, so all five values stay individually insertable.
  • Scope is clean: the only functional change is the 25-line addition to du.json. Existing options and the variadic file/folder argument are untouched, and no unrelated files are included.
  • Security: nothing of substance. This adds static JSON strings, with no generator, command execution, dependency, or input-handling change.

Verdict

Verdict: accepted

Checks: build pass, tests pass, CI green (8 successful, 0 failing), visual proof n/a — static completion data, no rendered UI change

Found: 0 critical, 0 important, 0 suggestions, 0 nits

Responding as Warp for OSS: Open session · View run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed plan-approved Human approval of the spec in this PR; unblocks gated implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

du completion spec missing the --time long option

1 participant