Add du --time completion option (#403) - #405
Conversation
|
This PR was generated with Warp. Comment |
|
Spec approved. This spec is approved for issue #403, and the spec stage is complete. Implementation is still gated: a maintainer can apply Responding as Warp for OSS: Open session · View run |
Adds the GNU --time option to du.json with an optional WORD argument, offering the documented atime/access/use (last access time) and ctime/status (last status-change time) value groups. Fixes #403
There was a problem hiding this comment.
Overview
Adds GNU du's --time option to command-signatures/json/du.json with an optional WORD argument and the documented value aliases, exactly as the approved GH403 spec prescribes. Net position: accepted.
Notes
- Correctness was checked against
du --help: bare--timeshows the last modification time, and the accepted values are exactlyatime,access,use,ctime,status. The description and the two alias groups match, and no undocumented value (such asmtime) is suggested. - The structure mirrors the
--colorpattern inls.json, and the alias arrays expand to one suggestion per spelling viacompletion-metadata/src/fig_types.rs, so all five values stay individually insertable. - Scope is clean: the only functional change is the 25-line addition to
du.json. Existing options and the variadic file/folder argument are untouched, and no unrelated files are included. - Security: nothing of substance. This adds static JSON strings, with no generator, command execution, dependency, or input-handling change.
Verdict
Verdict: accepted
Checks: build pass, tests pass, CI green (8 successful, 0 failing), visual proof n/a — static completion data, no rendered UI change
Found: 0 critical, 0 important, 0 suggestions, 0 nits
Responding as Warp for OSS: Open session · View run



Summary
Fixes #403.
Adds GNU
du's--timeoption tocommand-signatures/json/du.json, following the approved spec inspecs/GH403/.--timeis a single option with an optionalWORDargument (isOptional: true), so baredu --timeremains valid.du --time=offers the five documented GNU values grouped into two alias suggestions:atime/access/use— last access timectime/status— last status-change timels.json's--coloroption (norequiresEquals).Out of scope (per spec, unchanged):
--time-style=STYLE,--max-depth(#372), pairing short options with long aliases (#374).Validation
npm run format -- command-signatures/json/du.json— unchanged (already Prettier-formatted).script/presubmit— passed:npm run format:check,cargo fmt --check,cargo clippy --all-targets --all-features -- -D warnings, and the fullcargo testsuite (176 tests inwarp-command-signatures, includingall_command_specs_succeed_deserialization, plus 10 inwarp-completion-metadata), all green.