fix: match routes against the app's own base path for subfolder installs - #126
Merged
Merged
Conversation
Route::run() matched against the raw REQUEST_URI, so an app installed under a subdirectory (e.g. http://example.com/blog/) 404'd on every route unless each one was hand-prefixed with the install folder name. Url::base() already detected the subdirectory correctly for link generation; that detection is now exposed as Url::basePath() and used by a new Url::requestPath(), which strips it from the incoming URI before matching. Route::run() matches against requestPath() instead of uri(). Vite's production asset URLs are prefixed with the same base path so built CSS/JS resolve correctly too. Root installs are unaffected: basePath() is empty in that case, so requestPath() is identical to uri().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Route::run() matched against the raw REQUEST_URI, so an app installed under a subdirectory (e.g. http://example.com/blog/) 404'd on every route unless each one was hand-prefixed with the install folder name.
Url::base() already detected the subdirectory correctly for link generation; that detection is now exposed as Url::basePath() and used by a new Url::requestPath(), which strips it from the incoming URI before matching. Route::run() matches against requestPath() instead of uri(). Vite's production asset URLs are prefixed with the same base path so built CSS/JS resolve correctly too.
Root installs are unaffected: basePath() is empty in that case, so requestPath() is identical to uri().