feat: fetch apps and collaborators (WPB-25747) - #5220
Open
sbakhtiarov wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5220 +/- ##
========================================
Coverage 52.46% 52.46%
========================================
Files 739 739
Lines 25729 25734 +5
Branches 4220 4223 +3
========================================
+ Hits 13498 13502 +4
+ Misses 10940 10939 -1
- Partials 1291 1293 +2
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Contributor
Test Results2 622 tests 2 622 ✅ 1m 20s ⏱️ Results for commit 990b69e. |
yamilmedina
approved these changes
Aug 27, 2026
ohassine
reviewed
Aug 28, 2026
Comment on lines
+35
to
41
| Box( | ||
| modifier = modifier | ||
| .fillMaxWidth() | ||
| .wrapContentHeight() | ||
| .fillMaxSize() | ||
| .padding(dimensions().spacing16x), | ||
| horizontalAlignment = Alignment.CenterHorizontally, | ||
| verticalArrangement = Arrangement.Center, | ||
| ) { | ||
| Text( | ||
| text = stringResource(R.string.search_results_apps_empty_description_disabled_for_conversation), |
Member
There was a problem hiding this comment.
the new Box doesn't specify any alignment, the text will move to the top-start. we could use contentAlignment = Alignment.Center here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-25747
https://wearezeta.atlassian.net/browse/WPB-25747
What's new in this PR?
Issues
The Apps search relied on locally cached users, which can be incomplete for teams with more than 2,000 members. This could incorrectly show an empty Apps page even though apps were available.
Solutions
Refresh apps once when the Apps page is opened and wait for the refresh before resolving the initial empty-query results. Subsequent searches use the refreshed local cache without repeating the synchronization.
If refreshing fails, log the failure and continue using the existing cached apps.
When apps are disabled for the conversation, render the disabled-state content directly without creating the Apps ViewModel or making network requests. The legacy services flow remains unchanged.