Skip to content

test: close wolfSSH test_gap coverage hole #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JacobBarthelmeh merged 1 commit into from
Jul 28, 2026
Merged

test: close wolfSSH test_gap coverage hole #1100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 59 additions & 0 deletions apps/wolfsshd/test/test_configuration.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1342,6 +1342,65 @@ static int test_CheckPasswordHashUnix(void)
}
}

/* (a) empty input + empty stored hash -> SUCCESS (pins the empty branch). */
if (ret == WS_SUCCESS) {
char emptyStored[2];
emptyStored[0] = 0;
Log(" Testing scenario: empty password + empty stored hash authenticates.");
rc = CheckPasswordHashUnix("", emptyStored);
if (rc == WSSHD_AUTH_SUCCESS) {
Log(" PASSED.\n");
}
else {
Log(" FAILED.\n");
ret = WS_FATAL_ERROR;
}
}

/* (b) empty input + real $6$ hash -> FAILURE (kills the && -> || mutant). */
if (ret == WS_SUCCESS) {
Log(" Testing scenario: empty password + real hash is rejected.");
rc = CheckPasswordHashUnix("", stored);
if (rc == WSSHD_AUTH_FAILURE) {
Log(" PASSED.\n");
}
else {
Log(" FAILED.\n");
ret = WS_FATAL_ERROR;
}
}

/* (c) non-empty input + empty stored hash -> FAILURE. */
if (ret == WS_SUCCESS) {
char emptyStored[2];
emptyStored[0] = 0;
Log(" Testing scenario: non-empty password + empty stored hash is rejected.");
rc = CheckPasswordHashUnix(correct, emptyStored);
if (rc == WSSHD_AUTH_FAILURE) {
Log(" PASSED.\n");
}
else {
Log(" FAILED.\n");
ret = WS_FATAL_ERROR;
}
}

/* (d) locked account (stored[0]=='*') -> FAILURE (pins the '*' guard). */
if (ret == WS_SUCCESS) {
char lockedStored[3];
lockedStored[0] = '*';
lockedStored[1] = 0;
Log(" Testing scenario: locked account is rejected.");
rc = CheckPasswordHashUnix(correct, lockedStored);
if (rc == WSSHD_AUTH_FAILURE) {
Log(" PASSED.\n");
}
else {
Log(" FAILED.\n");
ret = WS_FATAL_ERROR;
}
}

return ret;
}
#endif /* WOLFSSH_HAVE_LIBCRYPT || WOLFSSH_HAVE_LIBLOGIN */
Expand Down
Loading