fix: missing WMALLOC NULL checks in sftpclient rm/rename#1124
Open
MarkAtwood wants to merge 1 commit into
Open
fix: missing WMALLOC NULL checks in sftpclient rm/rename#1124MarkAtwood wants to merge 1 commit into
MarkAtwood wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a NULL-dereference crash in the examples/sftpclient command handler by adding missing WMALLOC() failure checks in the rm and rename paths, consistent with other command handlers in doCmds().
Changes:
- Add
WMALLOC()NULL check for thermhandler before writing to the allocated buffer. - Add
WMALLOC()NULL check for therenamedestination buffer and free the already-allocated source buffer on failure.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
In the sftp client example's
doCmds(), thermandrenamehandlers callWMALLOCand then dereference the result without a NULL check:rm:f = WMALLOC(...)thenf[0] = '\0'(no check).rename: the first bufferfis checked, but the second,fTo = WMALLOC(...),is dereferenced (
fTo[0] = '\0') without one.The allocations use the system heap (
NULLctx), so on allocation failure theresult is a real NULL and the write is a NULL dereference / crash. Sibling
handlers (e.g.
mkdir, andrename's first buffer) already guard.Fix
Add the same
if (... == NULL)guard the sibling handlers use. Forrename'ssecond allocation, free the already-allocated
fbefore returning.Verification
Built
--enable-allagainst wolfSSL master; compiles clean.Reported by static analysis (Fenrir finding F-6973).