-
Notifications
You must be signed in to change notification settings - Fork 1k
cryptocb: add WC_ALGO_TYPE_KEYSTORE for hardware key store operations #11336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Frauschi
wants to merge
1
commit into
wolfSSL:master
Choose a base branch
from
Frauschi:cryptocb_keystore
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,934
−9
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # Known issues | ||
|
|
||
| Findings already investigated and closed. A scan that raises one of these again is re-reporting settled work; check the code before acting on it. | ||
|
|
||
| ## EdgeLock (els_pkc) port | ||
|
|
||
| - **ECDSA sign/verify stack overflow for digests over 80 bytes.** Not present. Both guards are `inlen > 255 || inlen > sizeof(hash)` (and `hashLen` likewise); the buffer bound is the second half of the condition, and reading only the first half suggests an overflow that cannot happen. `ElsPkcEccSign` and `ElsPkcEccVerify` in `wolfcrypt/src/port/nxp/els_pkc_port.c`, covered by the "oversized digest does not overflow the port buffer" check in the Zephyr sample. | ||
| - **`ElsRandom` violating the ELS DRBG word-multiple contract.** Handled deliberately: the whole-word part is generated into the caller's buffer and the remainder comes from a word-sized scratch, because declining would fail the call rather than fall back. Sizes 1 through 33 are exercised in the sample. | ||
| - **`ElsSha256Copy` leaking the destination's `msg` and `W` buffers.** Closed: `wc_Sha256Free(dst)` runs before the struct copy, for exactly this reason. | ||
| - **`ElsEccKeyGen` not validating the slot with `ElsCheckSlot()`.** By design. On a key generation the reference is a request rather than a lookup: the slot is empty and the key does not exist until the call returns, so a check requiring an active key would reject every valid keygen. | ||
| - **`wc_ElsPkc_HashOffloadCount` overstating the offload.** Fixed 2026-09-01; it now increments only after `ElsWait()` succeeds, so it counts engine runs rather than accepted updates. | ||
| - **No HMAC arm in the dispatch table.** Deliberate. The ELS HMAC command is one-shot while wolfCrypt drives HMAC incrementally, so an arm would have to buffer whole messages. HMAC is accelerated anyway because the inner hash inherits the devId. | ||
| - **RSA encrypt/decrypt (OAEP) declined.** Blocked upstream: every `MCUXCLRSA_ENCRYPT_*` and `_DECRYPT_*` workarea macro in NXP's `mcuxClRsa_MemoryConsumption.h` for rw61x is an unsubstituted `$(...)` template placeholder and will not compile. | ||
| - **AES-192, Ed448, deterministic ECDSA, SHA-1/SHA-3, AES-CCM/XTS/CFB/OFB declined.** The hardware has no such capability; each decline sits next to a comment saying so. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file relevant to the PR?