Gate out signature.h prototypes when NO_SIG_WRAPPER defined - #11488
Open
holtrop-wolfssl wants to merge 1 commit into
Open
holtrop-wolfssl wants to merge 1 commit into
holtrop-wolfssl wants to merge 1 commit into
Conversation
This causes a compile-time error rather than a link-time error since the function definitions were already gated out in signature.c.
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
This PR aligns the public signature wrapper declarations with the implementation configuration so disabled wrappers produce compile-time errors instead of link-time failures.
Changes:
- Moves automatic
NO_SIG_WRAPPERdetection intosignature.h. - Guards signature wrapper prototypes when
NO_SIG_WRAPPERis defined. - Removes duplicate detection from
signature.cand updates the Arduino configuration macro.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
wolfssl/wolfcrypt/signature.h |
Defines the wrapper-disabled state and conditionally exposes wrapper prototypes. |
wolfcrypt/src/signature.c |
Relies on the header-provided configuration guard. |
examples/configs/user_settings_arduino.h |
Uses NO_SIG_WRAPPER to disable signature wrappers. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Gate out signature.h prototypes when NO_SIG_WRAPPER defined
This causes a compile-time error rather than a link-time error since the function definitions were already gated out in signature.c.
This will be used by the fix to F-13036.
Testing
How did you test?
Checklist