fix: align Node engine with TanStack Start minimum - #121
mitch-fultz wants to merge 3 commits into
Conversation
|
@workos/typescript: please review the one-line Node minimum correction. GitHub rejected formal team assignment with HTTP 422 ( |
|
|
not opposed but package.json does not list this authkit-tanstack-start/package.json Line 35 in 0305539 |
|
TARS follow-through for Mitch: @gjtorikian, your package.json observation is correct—the SDK itself declares Node >=22.11.0. This README line describes the combined framework setup. Its peer requires @tanstack/react-start >=1.168.25, and that exact minimum Start version declares Node >=22.12.0. Fresh official registry reads confirm both today: AuthKit 0.11.0 and Start 1.168.25. The one-line README correction therefore uses the effective setup minimum without changing the SDK engine, claiming a reproduced 22.11 crash, or requiring a release. The five current-head checks pass at b2b4f7b; this is not human approval. Please review that distinction. Mitch retains normal upstream merge/native README sync and final publication/index/answer follow-through under DOC-593 and TARS-1411; this automation will not merge the SDK repository. |
|
Refreshed this branch with current main at f64270a (merge head eabed62). The PR still changes only the Node prerequisite from 22.11.0+ to 22.12.0+. Rechecked the minimum TanStack Start 1.168.25 npm metadata: it requires Node >=22.12.0. SDK build/typecheck, example build, README format check, and client-bundle leak check passed. Existing npm configuration warnings did not affect these checks. No SDK runtime or package requirements changed; human review and the normal README sync/publication remain outstanding. |
|
@workos/tars please update package.json |
|
Updated Formatting, SDK/example builds, bundle-leak check, and engine-range assertions passed. CI checks are pending. |
Summary
package.json(engines.node: ">=22.12.0").Evidence
The already-required minimum
@tanstack/react-start1.168.25 declares Node>=22.12.0. Its lockfile entry and installed package manifest agree, and both the README and SDK manifest now match that floor. This is a metadata alignment, not a claim that a Node 22.11 application crash was reproduced.Validation
Revalidated after the package change with Node 24.20.0 and CI's pnpm major 10 (10.34.5):
pnpm install --frozen-lockfile— passed; lockfile unchanged.pnpm run format:check— passed.pnpm run build— passed.pnpm --dir example build— passed, including the example TypeScript check.pnpm run build:check— passed; no server-side fingerprints in the client bundle.git diff --check— passed; the PR changes only the two Node minimum lines.The builds emitted non-blocking npm environment-config warnings and Vite's suggestion to replace
vite-tsconfig-pathswith native path resolution. No configuration was changed or warning suppressed. The full unit-test suite and CI matrix were not rerun locally for this metadata-only follow-up; the push triggers CI.Related work
Related: DOC-593 and TARS-1411.
These references intentionally do not close either issue. Normal review/merge, package release, native README sync and docs publication, and downstream index/answer verification remain separate follow-through. No generated mirror was hand-edited, and no merge, release, sync dispatch, browser, index, or model operation was performed for this update.