Skip to content

fix: align Node engine with TanStack Start minimum - #121

Open
mitch-fultz wants to merge 3 commits into
mainfrom
docs/doc-593-node-framework-minimum
Open

mitch-fultz wants to merge 3 commits into
mainfrom
docs/doc-593-node-framework-minimum

Conversation

@mitch-fultz

@mitch-fultz mitch-fultz commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Raise the Node.js minimum from 22.11.0 to 22.12.0 in both the README and package.json (engines.node: ">=22.12.0").
  • Include the package metadata correction requested in Garen's review follow-up; this PR is no longer documentation-only.
  • Leave framework versions, SDK runtime code, dependencies, examples, lockfile, and package version unchanged. The corrected package engine declaration will take effect through the normal package release process.

Evidence

The already-required minimum @tanstack/react-start 1.168.25 declares Node >=22.12.0. Its lockfile entry and installed package manifest agree, and both the README and SDK manifest now match that floor. This is a metadata alignment, not a claim that a Node 22.11 application crash was reproduced.

Validation

Revalidated after the package change with Node 24.20.0 and CI's pnpm major 10 (10.34.5):

  • pnpm install --frozen-lockfile — passed; lockfile unchanged.
  • pnpm run format:check — passed.
  • pnpm run build — passed.
  • pnpm --dir example build — passed, including the example TypeScript check.
  • pnpm run build:check — passed; no server-side fingerprints in the client bundle.
  • Focused metadata assertions — the manifest matches the README and minimum Start peer; the declared range excludes 22.11.x and accepts 22.12.0 and newer tested values; no other package metadata changed.
  • Complete diff review and git diff --check — passed; the PR changes only the two Node minimum lines.

The builds emitted non-blocking npm environment-config warnings and Vite's suggestion to replace vite-tsconfig-paths with native path resolution. No configuration was changed or warning suppressed. The full unit-test suite and CI matrix were not rerun locally for this metadata-only follow-up; the push triggers CI.

Related work

Related: DOC-593 and TARS-1411.

These references intentionally do not close either issue. Normal review/merge, package release, native README sync and docs publication, and downstream index/answer verification remain separate follow-through. No generated mirror was hand-edited, and no merge, release, sync dispatch, browser, index, or model operation was performed for this update.

@linear-code

linear-code Bot commented Sep 11, 2026

Copy link
Copy Markdown

DOC-593

@mitch-fultz

Copy link
Copy Markdown
Contributor Author

@workos/typescript: please review the one-line Node minimum correction. GitHub rejected formal team assignment with HTTP 422 (Reviews may only be requested from collaborators); @nicknisi and @gjtorikian have actual individual review requests. No permissions or review gates were changed.

@greptile-apps

greptile-apps Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge because its documentation and package metadata consistently reflect the framework’s effective Node.js minimum.

Summary

Updates the documented and declared minimum Node.js version to match the version required by TanStack Start 1.168.25.

  • Raises the README compatibility minimum from Node.js 22.11.0 to 22.12.0.
  • Raises the root package’s engines.node requirement to >=22.12.0.

Reviews (3) · Last reviewed commit: "fix: align Node engine with TanStack Sta..."

@gjtorikian

Copy link
Copy Markdown
Contributor

not opposed but package.json does not list this

"node": ">=22.11.0"

@workos-tars

workos-tars Bot commented Sep 16, 2026

Copy link
Copy Markdown

TARS follow-through for Mitch: @gjtorikian, your package.json observation is correct—the SDK itself declares Node >=22.11.0. This README line describes the combined framework setup. Its peer requires @tanstack/react-start >=1.168.25, and that exact minimum Start version declares Node >=22.12.0. Fresh official registry reads confirm both today: AuthKit 0.11.0 and Start 1.168.25.

The one-line README correction therefore uses the effective setup minimum without changing the SDK engine, claiming a reproduced 22.11 crash, or requiring a release. The five current-head checks pass at b2b4f7b; this is not human approval. Please review that distinction. Mitch retains normal upstream merge/native README sync and final publication/index/answer follow-through under DOC-593 and TARS-1411; this automation will not merge the SDK repository.

@workos-tars

workos-tars Bot commented Sep 16, 2026

Copy link
Copy Markdown

Refreshed this branch with current main at f64270a (merge head eabed62). The PR still changes only the Node prerequisite from 22.11.0+ to 22.12.0+. Rechecked the minimum TanStack Start 1.168.25 npm metadata: it requires Node >=22.12.0. SDK build/typecheck, example build, README format check, and client-bundle leak check passed. Existing npm configuration warnings did not affect these checks. No SDK runtime or package requirements changed; human review and the normal README sync/publication remain outstanding.

@gjtorikian

Copy link
Copy Markdown
Contributor

@workos/tars please update package.json

@workos-tars workos-tars Bot changed the title docs: Match TanStack Start's Node minimum fix: align Node engine with TanStack Start minimum Sep 18, 2026
@workos-tars

workos-tars Bot commented Sep 18, 2026

Copy link
Copy Markdown

Updated package.json to require Node >=22.12.0 and pushed in d4acc78, matching the README and TanStack Start. Updated the PR description to reflect the package change.

Formatting, SDK/example builds, bundle-leak check, and engine-range assertions passed. CI checks are pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants