Skip to content

chore: protect package installs with Socket Firewall - #1695

Merged
gjtorikian merged 3 commits into
mainfrom
chore/help-725-socket-firewall
Sep 11, 2026
Merged

chore: protect package installs with Socket Firewall#1695
gjtorikian merged 3 commits into
mainfrom
chore/help-725-socket-firewall

Conversation

@peakematt

Copy link
Copy Markdown
Contributor

Public pull request and release jobs currently install npm packages before Socket Firewall is active. This change adds the pinned Socket Firewall action before those installs so package downloads go through the WorkOS firewall registry. For public pull requests, checkout now avoids persisted credentials and the workflow keeps read-only permissions before enabling the action's external-fork fallback.

The npm publish workflow now tears down the same pinned action after build and test, before npm publish. The dependency-bump workflow keeps the existing version bump, lockfile, push, and pull request commands, but it now commits dependency updates while Socket Firewall is active and only pushes or opens downstream pull requests after teardown.

Manual verification: inspect the edited workflows and run actionlint -shellcheck= .github/workflows/ci.yml .github/workflows/runtime-tests.yml .github/workflows/release.yml .github/workflows/workos-node-dep-bump.yml.

Testing: the edited workflows pass GitHub Actions syntax checks with actionlint; the Socket Firewall conformance check reports no simple red flags for the changed install paths.

@linear-code

linear-code Bot commented Sep 9, 2026

Copy link
Copy Markdown

HELP-725

@peakematt
peakematt marked this pull request as ready for review September 9, 2026 00:43
@peakematt
peakematt requested review from a team as code owners September 9, 2026 00:43
@peakematt
peakematt requested a review from nicknisi September 9, 2026 00:43

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@greptile-apps

greptile-apps Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no outstanding actionable findings.

Summary

  • Adds Socket Firewall setup before npm and Bun-related dependency installation.
  • Tears down Socket Firewall before package publication and downstream repository pushes.
  • Separates dependency-bump commits from later push and pull-request operations.
  • Replaces inherited secrets with explicit forwarding of PUBLIC_SOCKET_FIREWALL_TOKEN.
  • The previous over-scoped-secrets finding is resolved by the current implementation.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Checkout and runtime setup] --> B[Configure Socket Firewall]
    B --> C[Install dependencies]
    C --> D[Build and test]
    D --> E[Teardown Socket Firewall]
    E --> F[Publish package or push dependency bumps]
Loading

Reviews (2) · Last reviewed commit: "chore: limit release workflow secret for..."

Comment thread .github/workflows/release-please.yml Outdated
@gjtorikian
gjtorikian merged commit a3e5545 into main Sep 11, 2026
7 checks passed
@gjtorikian
gjtorikian deleted the chore/help-725-socket-firewall branch September 11, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants