fix(go-ci): resolve a bare Go minor to the newest patch - #3
Merged
Conversation
setup-go matches a bare minor against the runner's toolcache before it looks for anything newer, so '1.26' kept resolving to a cached 1.26.5 well after 1.26.6 shipped. That failed govulncheck in a caller on 7 standard-library advisories the newer patch already fixed. Callers could pin a patch instead, but the matrix job name embeds the version string, and a branch ruleset requiring 'Test (ubuntu-latest, go1.26)' can never report once the name changes. check-latest keeps the name and the coverage gate's primary-version comparison intact while still picking up the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup-gomatches a bare minor against the runner's toolcache before it looks for anything newer, so1.26kept resolving to a cached 1.26.5 well after 1.26.6 shipped. That failed govulncheck in a caller on 7 standard-library advisories (GO-2026-5026,-5972,-6088..-6091,-6218) that the newer patch already fixes.Callers could pin the patch themselves, but that breaks in two places:
1.26.6renames the job toTest (ubuntu-latest, go1.26.6). A branch ruleset requiringTest (ubuntu-latest, go1.26)then waits forever on a check that can never report.primary-go-versionis compared againstmatrix.go-versionto pick the coverage combination. Overriding only the primary silently stops coverage uploads, because no matrix entry matches.check-latest: trueavoids both: job names and the coverage comparison stay as they are, and the security scans still run on the patched toolchain.Applied to all four
setup-gosteps (matrix, lint, security, verify) so the whole workflow agrees on the toolchain.🤖 Generated with Claude Code