Fix missing dstPath in Copy Bundle Resources phases - #1654
Open
Ckitakishi wants to merge 2 commits into
Open
Ckitakishi wants to merge 2 commits into
Ckitakishi wants to merge 2 commits into
Conversation
The generated "Copy Bundle Resources" phase omitted `dstPath`, and converting such a project to the Xcode 27.2 JSON format fails with "A copy build phase is missing a required value for destination path". Xcode-written projects carry the key with an empty path when no subpath is needed, and every other phase XcodeGen generates already does. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
XcodeGen omitted
dstPathwhen generating the "Copy Bundle Resources" copy files phase. Xcode-written projects carry the key with an empty value when no subpath is needed (Embed Frameworks,Embed App Extensions), and Xcode 27.2 rejects a missing value when converting a project to the newproject.xcprojformat.The generated phase now uses
dstPath: "", consistent with the other copy files phase generation paths.Reproduction
Requires Xcode 27.2, which added the
xcprojformat. Xcode 27.0 rejects it withCould not find requested format.project.yml:Before this change the conversion fails:
After it the conversion succeeds and replaces
project.pbxprojwithproject.xcproj. A failing conversion leaves the project untouched.Testing
dstPath == ""TestProjectfixture withdstPath = "";swift test