fix: ensure temp screenshot file cleanup on error paths - #418
Open
Ricardo-M-L wants to merge 1 commit into
Open
Conversation
Previously, the temp file created during ADB screenshot capture was only removed in the happy path. If Image.open() or any downstream operation raised an exception, the temp file would leak in the system temp directory. Move cleanup to a finally block to guarantee removal regardless of the code path taken.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR fixes
The ADB screenshot capture flow creates a temporary file in the system temp directory, but only cleaned it up in the happy-path execution. If Image.open() or any downstream operation (save, base64 encode) raised an exception, the temp file would leak in /tmp/.
Changes
Why this matters
Long-running automation sessions that encounter repeated screenshot errors can accumulate orphaned temp files, eventually filling the temp directory and causing filesystem issues.