fix: remove unused Tuple imports from screenshot modules - #419
Open
Ricardo-M-L wants to merge 1 commit into
Open
fix: remove unused Tuple imports from screenshot modules#419Ricardo-M-L wants to merge 1 commit into
Ricardo-M-L wants to merge 1 commit into
Conversation
The Tuple type was imported from typing in both adb/screenshot.py and hdc/screenshot.py but never used. These unused imports add noise and would trigger linting warnings in strict environments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR fixes
Both
phone_agent/adb/screenshot.pyandphone_agent/hdc/screenshot.pyimportTuplefromtypingbut never use it. These dead imports add noise and would trigger linting warnings in strict environments (e.g.flake8F401,ruffunused-import).Changes
from typing import Tuplefromphone_agent/adb/screenshot.pyfrom typing import Tuplefromphone_agent/hdc/screenshot.pyNotes
No functional changes — this is purely a code quality cleanup.