ci: pin publish-and-release job to Node 22.x - #2836
Merged
Merged
Conversation
Node 24.20.0 tightened WHATWG URL parsing, so resolving a path-absolute $ref against jsonschema's opaque `thismessage::/` base now throws ERR_INVALID_URL. That breaks `langium generate` (via jsonschema@1.5.0) and fails the language package build in the publish workflow. jsonschema@1.5.0 is the latest release, so pin the job to Node 22.x, matching the rest of CI. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe publish-and-release workflow now uses Node.js 22.x instead of Node.js 24.x. No other workflow behavior changed. ChangesRelease workflow
Estimated code review effort: 1 (Trivial) | ~2 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Publish and Release run for v3.9.4 failed in
@zenstackhq/language#build:Root cause
langium-clivalidateslangium-config.jsonwithjsonschema@1.5.0, which resolves$refs vianew URL(ref, 'thismessage::/'). That base has an opaque path, so resolving a path-absolute reference against it is invalid per the URL spec. Older Node/ada accepted it; Node 24.20.0 correctly throws.The publish job pinned
node-version: 24.xand the runner resolved it tov24.20.0(seenode: v24.20.0in the log). Nothing in v3.9.4 caused this — v3.9.3 published fine on Aug 31 with an older 24.x.Reproduced locally with
new URL('/undefined#/x', 'thismessage::/'):ERR_INVALID_URLRunning the exact
langium generateunder 24.20.0 reproduces the CI stack trace; under 24.18.0 it succeeds.Fix
jsonschema@1.5.0is the latest release, so there is no upgrade to take. Pin the publish job to Node 22.x, which is what everybuild-testjob already uses and passes on.🤖 Generated with Claude Code
Summary by CodeRabbit