Respect system color-scheme preference as default theme - #377
Open
Edward-Deakin wants to merge 2 commits into
Open
Edward-Deakin wants to merge 2 commits into
Edward-Deakin wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KV4vQhfyNV57p28BJMeGoq
Previously defaulted to light mode for first-time visitors with no saved preference or URL override, ignoring their OS dark-mode setting. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BvvYGNDv99R4wyjwanLMrB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prefers-color-schemesetting instead of hardcoding light mode when there's no savedthemein localStorage and nodocusaurus-themeURL override.docusaurus-themeURL param, which still takes priority, followed by any saved localStorage preference.Test plan
yarn build:js:esmpasses inpackages/docs-ui?docusaurus-theme=lightstill overrides system dark preference馃 Generated with Claude Code