Allow the repository image symlink in previews - #346
Closed
Blargian wants to merge 1 commit into
Closed
Conversation
Member
Author
|
Moved this fix directly to #345 as requested. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3ebed95. Configure here.
| target="$(readlink "$symlink")" | ||
| if [[ "$relative_path" == "public/images" && "$target" == "../images" ]]; then | ||
| continue | ||
| fi |
There was a problem hiding this comment.
Allowlist misses existing img symlink
High Severity
The new allowlist accepts only public/images → ../images, but the repository also ships public/img → ../img. The preview guard still rejects that existing link, so the upload fails before Vercel can build.
Reviewed by Cursor Bugbot for commit 3ebed95. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI preview guard rejected the repository's intentional
public/images→../imageslink before Vercel could build PR #345. Allow only that exact repository-contained path and target while continuing to reject every other symbolic link.Related: #345
Validated that the existing image link passes, an additional unapproved link fails, the workflow parses correctly, and the diff has no whitespace errors.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Not applicable.